git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [L10N] Kickoff for Git 2.37.0 round #1
@ 2022-06-14 11:28 Jiang Xin
  2022-06-19  8:02 ` Trần Ngọc Quân
  0 siblings, 1 reply; 5+ messages in thread
From: Jiang Xin @ 2022-06-14 11:28 UTC (permalink / raw)
  To: Git l10n discussion group, Alexander Shopov, Jordi Mas,
	Matthias Rüster, Jimmy Angelakos, Christopher Díaz,
	Jean-Noël Avila, Bagas Sanjaya, Alessandro Menti,
	Gwan-gyeong Mun, Arusekk, Daniel Santos, Dimitriy Ryazantcev,
	Peter Krefting, Emir SARI, Trần Ngọc Quân,
	Fangyi Zhou, Yi-Jyun Pan
  Cc: Jiang Xin, Git List

Hi,

Git v2.37.0-rc0 has been released, and it's time to start new round of
git l10n.  This time there are 92 updated messages need to be translated
since last release. Please send your pull request to the l10n coordinator's
repository below before this update window closes on Sun, June 26, 2022. 

    https://github.com/git-l10n/git-po/

As of git 2.37, we (git l10n contributors) have a new l10n workflow. The
following description of the new l10n workflow is from the "po/README.md"
file.


## The "po/git.pot" file is a generated file, no longer in the repository

The l10n coordinator does not need to generate the "po/git.pot" file every
time to start a new l10n workflow, and there is no "po/git.pot" file at all.

Everyone can generate the "po/git.pot" file with the command below:

    make po/git.pot

But we can also forget about it. By updating our corresponding "po/XX.po"
file, the "po/git.pot" file is automatically generated.


## Update the "po/XX.po" file, and start to translate

Before updating the "po/XX.po" file, l10n contributors should pull the latest
commits from the master branch of "git.git". E.g.:

    git pull --rebase git@github.com:git/git.git master

Then update the cooresponding "po/XX.po" file using the following command:

    make po-update PO_FILE=po/XX.po

Translate the uptodate "po/XX.po" file, and create a new commit.


## Refine your commits, send pull requests

In the "po/XX.po" file, there are location lines in comments like below:

    #: add-interactive.c:535 add-interactive.c:836 reset.c:136 sequencer.c:3505
    #: sequencer.c:3970 sequencer.c:4127 builtin/rebase.c:1261
    #: builtin/rebase.c:1671

These comments with file locations are useful for l10n contributors to locate
the context easily during translation. But these file locations introduce a
lot of noise and will consume a lot of repository storage. Therefore, we
should remove these file locations from the "po/XX.po" file.

To remove file locations in the "po/XX.po" file, you can use one of the
following two ways, but don't switch back and forth.

 * Keep the filenames, only remove locations (need gettext 0.19 and above):

        msgcat --add-location=file po/XX.po >po/XX.po.new
        mv po/XX.po.new po/XX.po

 * Remove both filenames and locations:

        msgcat --no-location po/XX.po >po/XX.po.new
        mv po/XX.po.new po/XX.po

After squashing trivial commits and removing file locations in the "po/XX.po"
file, send pull request to the l10n coordinator's repository below:

    https://github.com/git-l10n/git-po/


## Resolve errors found by the l10n CI pipeline for the pull request

A helper program hosted on "https://github.com/git-l10n/git-po-helper" can
help git l10n coordinator and git l10n contributors to check the conventions
of git l10n contributions, and it is also used in GitHub actions as l10n CI
pipeline to validate each pull request in the "git-l10n/git-po" repository.
Please fix the issues found by the helper program.


** Please note: The update window will close on Sun, June 26, 2022. **


--
Jiang Xin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [L10N] Kickoff for Git 2.37.0 round #1
  2022-06-14 11:28 [L10N] Kickoff for Git 2.37.0 round #1 Jiang Xin
@ 2022-06-19  8:02 ` Trần Ngọc Quân
  2022-06-19 12:13   ` Jiang Xin
  0 siblings, 1 reply; 5+ messages in thread
From: Trần Ngọc Quân @ 2022-06-19  8:02 UTC (permalink / raw)
  To: Jiang Xin
  Cc: Git l10n discussion group, Alexander Shopov, Jordi Mas,
	Matthias Rüster, Jimmy Angelakos, Christopher Díaz,
	Jean-Noël Avila, Bagas Sanjaya, Alessandro Menti,
	Gwan-gyeong Mun, Arusekk, Daniel Santos, Dimitriy Ryazantcev,
	Peter Krefting, Emir SARI, Fangyi Zhou, Yi-Jyun Pan, Git List

On Tue, Jun 14, 2022 at 6:29 PM Jiang Xin <worldhello.net@gmail.com> wrote:
>
> Hi,
>
> Git v2.37.0-rc0 has been released, and it's time to start new round of
> git l10n.  This time there are 92 updated messages need to be translated
> since last release. Please send your pull request to the l10n coordinator's
> repository below before this update window closes on Sun, June 26, 2022.
>
>     https://github.com/git-l10n/git-po/
>
Done, please pull!

$ git log -n1 --stat
commit 22262d3c1947626e296418ffa3543d3584995653 (HEAD -> master, origin/master,
origin/HEAD)
Author: Trần Ngọc Quân <vnwildman@gmail.com>
Date:   Sun Jun 19 07:48:40 2022 +0700

    l10n: vi(5367t): Updated Vietnamese translation v2.37

    Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>

 po/vi.po | 37548 +++++++++++++++++++++++++++++++------------------------------
 1 file changed, 19003 insertions(+), 18545 deletions(-)



-- 
Regards,
Trần Ngọc Quân

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [L10N] Kickoff for Git 2.37.0 round #1
  2022-06-19  8:02 ` Trần Ngọc Quân
@ 2022-06-19 12:13   ` Jiang Xin
  2022-06-22 14:26     ` Peter Krefting
  0 siblings, 1 reply; 5+ messages in thread
From: Jiang Xin @ 2022-06-19 12:13 UTC (permalink / raw)
  To: Trần Ngọc Quân
  Cc: Git l10n discussion group, Alexander Shopov, Jordi Mas,
	Matthias Rüster, Jimmy Angelakos, Christopher Díaz,
	Jean-Noël Avila, Bagas Sanjaya, Alessandro Menti,
	Gwan-gyeong Mun, Arusekk, Daniel Santos, Dimitriy Ryazantcev,
	Peter Krefting, Emir SARI, Fangyi Zhou, Yi-Jyun Pan, Git List

On Sun, Jun 19, 2022 at 4:02 PM Trần Ngọc Quân <vnwildman@gmail.com> wrote:
>
> On Tue, Jun 14, 2022 at 6:29 PM Jiang Xin <worldhello.net@gmail.com> wrote:
> >
> > Hi,
> >
> > Git v2.37.0-rc0 has been released, and it's time to start new round of
> > git l10n.  This time there are 92 updated messages need to be translated
> > since last release. Please send your pull request to the l10n coordinator's
> > repository below before this update window closes on Sun, June 26, 2022.
> >
> >     https://github.com/git-l10n/git-po/
> >
> Done, please pull!
>
> $ git log -n1 --stat
> commit 22262d3c1947626e296418ffa3543d3584995653 (HEAD -> master, origin/master,
> origin/HEAD)
> Author: Trần Ngọc Quân <vnwildman@gmail.com>
> Date:   Sun Jun 19 07:48:40 2022 +0700
>
>     l10n: vi(5367t): Updated Vietnamese translation v2.37
>
>     Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
>
>  po/vi.po | 37548 +++++++++++++++++++++++++++++++------------------------------
>  1 file changed, 19003 insertions(+), 18545 deletions(-)

You forgot to remove file-location comments in "po/vi.po".  If you
send me pull request on GitHub, a CI workflow will be triggered to
execute the command below,

    $ git-po-helper check-commits --github-action-event=push <rev-list-args>

and you will receive the following report:

------------------------------------------------------------------------------
INFO [po/vi.po@22262d3] 5367 条已翻译消息.
------------------------------------------------------------------------------
ERROR [po/vi.po@22262d3]        Found file-location comments in po
file. By submitting a location-less
ERROR [po/vi.po@22262d3]        "po/XX.po" file, the size of the Git
repository can be greatly reduced.
ERROR [po/vi.po@22262d3]        See the discussion below:
ERROR [po/vi.po@22262d3]
ERROR [po/vi.po@22262d3]
https://lore.kernel.org/git/20220504124121.12683-1-worldhello.net@gmail.com/
ERROR [po/vi.po@22262d3]
ERROR [po/vi.po@22262d3]        As how to commit a location-less
"po/XX.po" file, See:
ERROR [po/vi.po@22262d3]
ERROR [po/vi.po@22262d3]            the [Updating a "XX.po" file]
section in "po/README.md"
------------------------------------------------------------------------------
WARNING commit 22262d3: subject length 53 > 50, about 63% commits have
a subject less than 50 characters
INFO checking commits: 0 passed, 1 failed.
------------------------------------------------------------------------------
INFO update pot file by running: make pot

ERROR: fail to execute "git-po-helper check-commits"

Will turn on the switch for file-location checking by default in
git-po-helper check-po, check-command, etc.

--
Jiang Xin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [L10N] Kickoff for Git 2.37.0 round #1
  2022-06-19 12:13   ` Jiang Xin
@ 2022-06-22 14:26     ` Peter Krefting
  2022-06-23  1:12       ` Jiang Xin
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Krefting @ 2022-06-22 14:26 UTC (permalink / raw)
  To: Jiang Xin
  Cc: Trần Ngọc Quân, Git l10n discussion group,
	Alexander Shopov, Jordi Mas, Matthias Rüster,
	Jimmy Angelakos, Christopher Díaz, Jean-Noël Avila,
	Bagas Sanjaya, Alessandro Menti, Gwan-gyeong Mun, Arusekk,
	Daniel Santos, Dimitriy Ryazantcev, Emir SARI, Fangyi Zhou,
	Yi-Jyun Pan, Git List

On Sun, 19 Jun 2022, Jiang Xin wrote:

> You forgot to remove file-location comments in "po/vi.po".  If you
> send me pull request on GitHub, a CI workflow will be triggered to
> execute the command below,

Is that why the sv.po pull request is also standing still?

Running "make po/git.pot" generates the full location lines, so naturally
the PO file will also include it. If the makefile is fixed to remove them
they should go away.

I modified my update script to run make first, as you removed git.pot from
the repo, and it generates it there.

-- 
\\// Peter - http://www.softwolves.pp.se/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [L10N] Kickoff for Git 2.37.0 round #1
  2022-06-22 14:26     ` Peter Krefting
@ 2022-06-23  1:12       ` Jiang Xin
  0 siblings, 0 replies; 5+ messages in thread
From: Jiang Xin @ 2022-06-23  1:12 UTC (permalink / raw)
  To: Peter Krefting
  Cc: Tr¥n Ng÷c Quân, Git l10n discussion group,
	Alexander Shopov, Jordi Mas, Matthias Rüster,
	Jimmy Angelakos, Christopher Díaz, Jean-Noël Avila,
	Bagas Sanjaya, Alessandro Menti, Gwan-gyeong Mun, Arusekk,
	Daniel Santos, Dimitriy Ryazantcev, Emir SARI, Fangyi Zhou,
	Yi-Jyun Pan, Git List

On Wed, Jun 22, 2022 at 10:26 PM Peter Krefting <peter@softwolves.pp.se> wrote:
>
> On Sun, 19 Jun 2022, Jiang Xin wrote:
>
> > You forgot to remove file-location comments in "po/vi.po".  If you
> > send me pull request on GitHub, a CI workflow will be triggered to
> > execute the command below,
>
> Is that why the sv.po pull request is also standing still?

You may already notice the error report from the CI pipeline in the
PR[1], you should:

 1. remove file-location comments from "po/sv.po".
 2. update your translation based on the master branch of
     "git/git" or "git-l10n/git-po" repository.

After you fix all the above errors , and there are no more l10n
updates upstream, like 2.37.0-rc2 is released, I'll merge your PR.

[1]: https://github.com/git-l10n/git-po/pull/640

--
Jiang Xin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-23  1:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 11:28 [L10N] Kickoff for Git 2.37.0 round #1 Jiang Xin
2022-06-19  8:02 ` Trần Ngọc Quân
2022-06-19 12:13   ` Jiang Xin
2022-06-22 14:26     ` Peter Krefting
2022-06-23  1:12       ` Jiang Xin

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).