From: Jiang Xin <worldhello.net@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: cc/list-objects-filter-wo-sparse-path, was Re: What's cooking in git.git (May 2019, #05; Thu, 30)
Date: Sun, 2 Jun 2019 22:32:44 +0800 [thread overview]
Message-ID: <CANYiYbEYcZu3hOXdvFXo-hZo-=vZobYX-M-0dGMmp4TKM3p3nA@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1905312224020.1775@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> 于2019年6月1日周六 上午4:26写道:
>
> Hi Junio,
>
> On Fri, 31 May 2019, Junio C Hamano wrote:
>
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> > >> * cc/list-objects-filter-wo-sparse-path (2019-05-29) 1 commit
> > >> (merged to 'next' on 2019-05-30 at 5a294203ad)
> > >> + list-objects-filter: disable 'sparse:path' filters
> > >>
> > >> Disable "--filter=sparse:path=<path>" that would allow reading from
> > >> paths on the filesystem.
> > >>
> > >> Will cook in 'next'.
> > >
> > > Not sure whether we want to fast-track this into v2.22.0. There is a risk.
> > >
> > > But then, the longer we ship with `--filter=sparse:path` *enabled*, the
> > > more we invite users to actually try and use it.
> >
> > This one I wasn't quite decided on, for exactly the same reason why
> > you said "Not sure". I am inclined to merge it to 'master' at this
> > point, as it indeed is a risk to keep it enabled.
> >
> > The only remaining question it raises is if it makes it worthwhile
> > to add another rc; it introduces one new localizable string, too.
>
> That'd be more a question to the L10N coordinator (who you Cc:ed)... Jiang
> Lin? Would that require another -rc?
Current l10n round 2 is based on v2.22.0-rc2, and only 5 days left for the
final release. If merge the topic "cc/list-objects-filter-wo-sparse-path" to
master, a -rc3 is needed for the new message introduced:
+#: list-objects-filter-options.c:84
+msgid "sparse:path filters support has been dropped"
+msgstr ""
--
Jiang Xin
next prev parent reply other threads:[~2019-06-02 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 21:23 What's cooking in git.git (May 2019, #05; Thu, 30) Junio C Hamano
2019-05-31 11:39 ` Johannes Schindelin
2019-05-31 17:02 ` Junio C Hamano
2019-05-31 17:14 ` Johannes Schindelin
2019-05-31 12:42 ` Johannes Schindelin
2019-05-31 17:34 ` Junio C Hamano
2019-05-31 18:48 ` Johannes Schindelin
2019-06-01 15:08 ` Kaartic Sivaraam
2019-06-02 17:48 ` Philip Oakley
2019-05-31 18:56 ` Junio C Hamano
2019-05-31 20:26 ` cc/list-objects-filter-wo-sparse-path, was " Johannes Schindelin
2019-06-02 14:32 ` Jiang Xin [this message]
2019-06-05 18:38 ` Nickolai Belakovski
2019-06-06 13:09 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANYiYbEYcZu3hOXdvFXo-hZo-=vZobYX-M-0dGMmp4TKM3p3nA@mail.gmail.com' \
--to=worldhello.net@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).