Re: [PATCH v15 01/16] test: add test cases for relative_path

[Jiang Xin <worldhello.net@gmail.com>]

2013/6/27 Junio C Hamano <gitster@pobox.com>
>
> Jiang Xin <worldhello.net@gmail.com> writes:
>
> > Add subcommand "relative_path" in test-path-utils, and add test cases
> > in t0060.
> >
> > Johannes tested this commit on Windows, and found that some relative_path
>
> "this commit", or "an earlier version of this patch"?  I am guessing
> it is the latter (if so, I can easily amend locally without a need
> for rerolling).

Sorry, my English. I should say: Johannes helped to test these test cases on
Windows, and found that ...

>
> > tests should be skipped on Windows. This is because the bash on Windows
> > rewrites arguments of regular Windows programs, such as git and the
> > test helpers, if the arguments look like absolute POSIX paths. As a
> > consequence, the actual tests performed are not what the tests scripts
> > expect.
> >
> > The tests that need *not* be skipped are those where the two paths passed
> > to 'test-path-utils relative_path' have the same prefix and the result is
> > expected to be a relative path. This is because the rewriting changes
> > "/a/b" to "D:/Src/MSysGit/a/b", and when both inputs are extended the same
> > way, this just cancels out in the relative path computation.
> >
> > Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
> > Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> I somehow lost track, but does the above list of sign-offs reflect
> the origins of the changes contained in this patch, or is the second
> one meant to be helped-by or something (if so, I can easily amend
> locally without a need for rerolling)?

Johannes offered a nice patch based on the last one of this
patch series. I move his patch right after the first patch
(patch 01: test: add test cases for relative_path). But I think
as a cooking topic, it should not has a commit to fix another.
So I squash Johannes' commit to the previous commit, and
add his signed-off-by.


--
Jiang Xin