mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Andreas Hasenack <>
Subject: /proc/cpuinfo regexp fails on s390x
Date: Tue, 22 Nov 2022 14:37:38 -0300	[thread overview]
Message-ID: <> (raw)


(please CC me on replies, as I'm not subscribed)

git commit 29fb2ec384a867ca577335a12f4b45c184e7b642[1], present in
2.38.0 and later, introduced a function that gets the number of cores
from /proc/cpuinfo. It essentially does this on linux:

    do { local @ARGV='/proc/cpuinfo'; return
scalar(grep(/^processor\s*:/, <>)); } if -r '/proc/cpuinfo';

On s390x, the ^processor lines are like this:

processor 0: version = FF, identification = 148F67, machine = 2964

In other arches (I checked amd64, armhf and arm64), they are like this instead:

processor : 0

As a result, that function is returning 0 on s390x, and that value is
used for the number of jobs the script should execute. Since it's
zero, it exits without doing anything, and that breaks the test and
the build[3] on s390x.

This is trivial and I don't think a PR is necessary, but let me know
if you want one.

That regexp could perhaps be:




or something else.


             reply	other threads:[~2022-11-22 17:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 17:37 Andreas Hasenack [this message]
2022-11-22 17:57 ` /proc/cpuinfo regexp fails on s390x Eric Sunshine
2022-11-22 18:04   ` Andreas Hasenack
2022-11-22 18:13     ` Eric Sunshine
2022-11-22 18:42       ` Andreas Hasenack
2022-11-22 19:39         ` Eric Sunshine
2022-11-22 23:30 ` Andreas Schwab
2022-11-22 23:50   ` Eric Sunshine
2022-11-23  9:27     ` Andreas Schwab
2022-11-23 19:10       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).