mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Andreas Hasenack <>
To: Junio C Hamano <>
Cc: Eric Sunshine <>,
	Andreas Hasenack via GitGitGadget <>,
Subject: Re: [PATCH] fix /proc/cpuinfo regexp
Date: Wed, 23 Nov 2022 09:16:51 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <xmqqsfiao47q.fsf@gitster.g>

Should I still change the commit message regarding where I mention the
commit that introduced this, as explained by Eric? From the activity I
saw overnight it looks like things were already picked up and it
doesn't matter anymore.

On Tue, Nov 22, 2022 at 10:21 PM Junio C Hamano <> wrote:
> Eric Sunshine <> writes:
> > Makes sense. Well explained.
> >
> > A separate problem is that doesn't fall back to a
> > sensible non-zero value if ncores() returns 0 (or some other nonsense
> > value). That is, of course, outside the scope of the well-focused
> > problem fix which this standalone patch addresses. I may end up
> > submitting a fix separately to make it fall back sensibly.
> > ...
> > As mentioned elsewhere[1], this code may eventually be dropped
> > altogether, but this fix is good to have in the meantime. Thanks.
> Thanks, both.  Will apply.

  reply	other threads:[~2022-11-23 12:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 20:27 [PATCH] fix /proc/cpuinfo regexp Andreas Hasenack via GitGitGadget
2022-11-22 20:57 ` Eric Sunshine
2022-11-23  1:21   ` Junio C Hamano
2022-11-23 12:16     ` Andreas Hasenack [this message]
2022-11-23 15:52       ` Eric Sunshine
2022-11-23 23:53       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).