git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Jakub Narębski" <jnareb@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Tony Finch <dot@dotat.at>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail
Date: Thu, 4 Jul 2013 00:11:01 +0200	[thread overview]
Message-ID: <CANQwDwcneUzzXS-Du-3Aca3-Vp8ycSzVqUv1rVRVhaNUWfeokw@mail.gmail.com> (raw)
In-Reply-To: <20130703215930.GT408@google.com>

On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Tony Finch wrote:

>> +@extra_breadcrumbs::
>> +     Additional links to be added to the start of the breadcrumb trail,
>> +     that are logically "above" the gitweb projects list. For example,
>> +     links to the organization and department which host the gitweb
>> +     server. Each element of the list is a reference to an array,
>> +     in which element 0 is the link text and element 1 is the
>> +     target URL.
>
> Is arbitrary HTML permitted in the link text?
>
> I think it makes sense to permit it for consistency with $home_link_str,
> but it might be worth mentioning in the manpage so the administrator
> knows not to set it to something user-controlled --- e.g.:
>
>         The link text can contain arbitrary HTML --- to escape link
>         text generated programatically, use esc_html($text).

Nb. it would be nice to have relation of @extra_breadcrumbs with
$home_link_str explained.

-- 
Jakub Narebski

  reply	other threads:[~2013-07-03 22:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 15:49 [PATCH] gitweb: allow extra breadcrumbs to prefix the trail Tony Finch
2013-07-02 15:49 ` [PATCH v2] " Tony Finch
2013-07-03 21:59 ` [PATCH] " Jonathan Nieder
2013-07-03 22:11   ` Jakub Narębski [this message]
2013-07-04  8:44     ` Tony Finch
2013-07-04 14:40       ` Jakub Narębski
2013-07-04 15:11         ` Tony Finch
2013-07-04 15:34           ` Jakub Narębski
2013-07-04 15:56             ` Tony Finch
2013-07-04 16:32               ` Jakub Narębski
2013-07-04 17:08                 ` Tony Finch
2013-07-04 17:31                   ` Jakub Narębski
2013-07-04 17:02 ` [PATCH v3] " Tony Finch
2013-07-04 17:42   ` Jakub Narębski
2013-07-07  1:05   ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANQwDwcneUzzXS-Du-3Aca3-Vp8ycSzVqUv1rVRVhaNUWfeokw@mail.gmail.com \
    --to=jnareb@gmail.com \
    --cc=dot@dotat.at \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).