From: Neeraj Singh <nksingh85@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Neeraj Singh via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
"Neeraj K. Singh" <neerajsi@microsoft.com>
Subject: Re: [PATCH 2/2] tmp-objdir: disable ref updates when replacing the primary odb
Date: Sun, 5 Dec 2021 19:10:04 -0800 [thread overview]
Message-ID: <CANQDOdfyoEM0pELKWzoK5ZUrDqwWnQLtbAycESzCqRRdWyWUSA@mail.gmail.com> (raw)
In-Reply-To: <xmqqsfv6ip1y.fsf@gitster.g>
On Sun, Dec 5, 2021 at 3:56 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Neeraj Singh <nksingh85@gmail.com> writes:
>
> > On Sun, Dec 05, 2021 at 10:23:08AM -0800, Junio C Hamano wrote:
> >> "Neeraj Singh via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >>
> >> > /*
> >> > * This object store is ephemeral, so there is no need to fsync.
> >> > */
> >> > - int will_destroy;
> >> > + unsigned int will_destroy : 1;
> >>
> >> <CANQDOddCC7+gGUy1VBxxwvN7ieP+N8mQhbxK2xx6ySqZc6U7-g@mail.gmail.com>
> >> ?
> >>
> >> (https://github.com/git/git/pull/1076#discussion_r750645345)
> >
> > Thanks for noticing this! I also lost one other change
> > while splitting this out: we are referencing
> > the_repository from the refs code, but as of 34224e14d we
> > should be picking it up from the ref_store. I'll submit
> > an updated series as soon as it passes CI.
>
> No rush.
>
> Reviewers and other project participants would appreciate you more
> if you took a deep breath, after seeing a CI success, and gave a
> final re-reading of the patches with a critical pair of eyes, before
> you send the updated series out.
>
> Thanks.
Fair enough. Of course I didn't see your email before I resubmitted.
Thanks for the feedback.
next prev parent reply other threads:[~2021-12-06 3:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 2:40 [PATCH 0/2] ns/tmp-objdir: add support for temporary writable databases Neeraj K. Singh via GitGitGadget
2021-12-04 2:40 ` [PATCH 1/2] tmp-objdir: new API for creating " Neeraj Singh via GitGitGadget
2021-12-04 2:40 ` [PATCH 2/2] tmp-objdir: disable ref updates when replacing the primary odb Neeraj Singh via GitGitGadget
2021-12-05 18:23 ` Junio C Hamano
2021-12-05 23:44 ` Neeraj Singh
2021-12-05 23:56 ` Junio C Hamano
2021-12-06 3:10 ` Neeraj Singh [this message]
2021-12-06 0:36 ` [PATCH v2 0/2] ns/tmp-objdir: add support for temporary writable databases Neeraj K. Singh via GitGitGadget
2021-12-06 0:36 ` [PATCH v2 1/2] tmp-objdir: new API for creating " Neeraj Singh via GitGitGadget
2021-12-06 7:43 ` Junio C Hamano
2021-12-06 8:53 ` Neeraj Singh
2021-12-06 17:39 ` Junio C Hamano
2021-12-06 0:36 ` [PATCH v2 2/2] tmp-objdir: disable ref updates when replacing the primary odb Neeraj Singh via GitGitGadget
2021-12-06 3:12 ` Neeraj Singh
2021-12-06 22:05 ` [PATCH v3 0/2] ns/tmp-objdir: add support for temporary writable databases Neeraj K. Singh via GitGitGadget
2021-12-06 22:05 ` [PATCH v3 1/2] tmp-objdir: new API for creating " Neeraj Singh via GitGitGadget
2021-12-06 22:05 ` [PATCH v3 2/2] tmp-objdir: disable ref updates when replacing the primary odb Neeraj Singh via GitGitGadget
2021-12-08 16:41 ` [PATCH v3 0/2] ns/tmp-objdir: add support for temporary writable databases Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANQDOdfyoEM0pELKWzoK5ZUrDqwWnQLtbAycESzCqRRdWyWUSA@mail.gmail.com \
--to=nksingh85@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=neerajsi@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).