git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: git@vger.kernel.org
Subject: Re: Refresh index without discard_index + repo_read_index
Date: Mon, 11 Mar 2019 17:00:20 +0100	[thread overview]
Message-ID: <CAN=4vMpN2UrZvJSedCyP=oh7aXTj5hWg9Yq6tfdTxMd895Rpxg@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMp1+=hmdRiuC1Y-4w2iKbSuwgAi54ozDzK2dGwn7J=QUQ@mail.gmail.com>

In the end I managed to patch diffing code in libgit2
(git_diff_tree_to_index and git_diff_index_to_workdir) to make it
about 4x faster. It's now faster than `git status`, so good enough for
me.

I'm still curious whether it's possible to refresh index in git (not
libgit2), so please chime if if you know.

Roman.

On Sat, Mar 9, 2019 at 8:59 PM Roman Perepelitsa
<roman.perepelitsa@gmail.com> wrote:
>
> I’m writing a program that reads stdin in a loop and prints the
> equivalent of `git status` whenever it reads a character. It always
> prints its results for the same repository, the same pathspec, etc.
> The input characters have no effect on the output, only the sate of
> the repository does.
> I’m hoping that I can make it produce results faster than a bash
> script that literally calls `git status` in a loop. I’m thinking that
> maybe I can keep some caches around so that I don’t have to redo all
> the work on every iteration that git status does.
>
> What I cannot figure out is how to refresh the index so that it picks
> up all the changes that might have happened to the repository and
> workdir since the last iteration. Here’s what I have:
>
> ```c
> #include <stdio.h>
> #include <string.h>
>
> #define USE_THE_INDEX_COMPATIBILITY_MACROS
> #include "cache.h"
> #include "wt-status.h"
> #include "pathspec.h"
> #include "repository.h"
>
> int cmd_multi_status(int argc, const char** argv, const char* prefix) {
>   struct pathspec pathspec;
>   memset(&pathspec, 0, sizeof(pathspec));
>   repo_read_index(the_repository);
>   while (getchar() != EOF) {
>     refresh_index(&the_index,
>                   REFRESH_QUIET | REFRESH_UNMERGED | REFRESH_REALLY,
>                   &pathspec, NULL, NULL);
>     int uncommitted = has_uncommitted_changes(the_repository, 1);
>     int unstaged = has_unstaged_changes(the_repository, 1);
>     int untracked = has_untracked(the_repository);  // I added this to
> wt-status.h
>     printf("%d %d %d\n", uncommitted, unstaged, untracked);
>   }
>   return 0;
> }
> ```
>
> This produces correct results on the first iteration but then it
> doesn’t pick up all changes. I’ve hacked some code in preload-index.c
> and cache.c so that it picks up more changes but I still cannot detect
> when an unstaged file becomes uncommitted or the other way around.
>
> Any pointers would be greatly appreciated.
>
> Roman.
>
> P.S.
>
> I have working code that uses libgit2. Updating the index with
> `git_index_read(index, 0)` works as expected and is indeed faster than
> discarding the index and starting from scratch. But it's still slower
> than `git status` on large repositories, especially with many ignored
> files.

      reply	other threads:[~2019-03-11 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09 19:59 Refresh index without discard_index + repo_read_index Roman Perepelitsa
2019-03-11 16:00 ` Roman Perepelitsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN=4vMpN2UrZvJSedCyP=oh7aXTj5hWg9Yq6tfdTxMd895Rpxg@mail.gmail.com' \
    --to=roman.perepelitsa@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).