git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "Miriam R." <mirucam@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v7 00/13] Finish converting git bisect to C part 2
Date: Wed, 23 Sep 2020 09:26:58 +0200	[thread overview]
Message-ID: <CAN7CjDDVp_i7dhpbAq5zrGW69nE6+SfivJQ-dembmu+WyqKiQQ@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2009031403510.56@tvgsbejvaqbjf.bet>

Hi Johannes,

El jue., 3 sept. 2020 a las 22:29, Johannes Schindelin
(<Johannes.Schindelin@gmx.de>) escribió:
>
> Hi Miriam,
>
>
> On Mon, 31 Aug 2020, Miriam Rubio wrote:
>
> > These patches correspond to a second part of patch series
> > of Outreachy project "Finish converting `git bisect` from shell to C"
> > started by Pranit Bauva and Tanushree Tumane
> > (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
> > continued by me.
> >
> > These patch series emails were generated from:
> > https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v7.
>
> Excellent progress, and thank you for your patience and diligence working
> on this patch series. I think we are _really_ close to being ready for
> `next`.
>
Thank you for your comments and encouragement.
Applying some of your suggestions related to removing some 'eval' in
git-bisect shell script, a bug has appeared. It seems it is related to
a previous code merged before my internship.
Christian Couder will take over this fix, but in the meantime I will
send a subset of this part2, with the first six patches of this patch
series (and that are not affected by the problem) in order to move
them forward and be accepted, hopefully .
Best,
Miriam




> Thanks!
> Johannes
>
> >
> > I would like to thank Junio Hamano for reviewing this patch series.
> >
> > General changes
> > ---------------
> >
> > * Rebased on e9b77c84a0 (Tenth batch, 2020-08-24), to build on the
> >   strvec API (instead of argv_array) and adjust to the codebase
> >   after the "--first-parent" feature was added.
> >
> >
> > Specific changes
> > ----------------
> >
> > [1/13] bisect--helper: BUG() in cmd_*() on invalid subcommand
> >
> > * Amend commit message.
> > * Remove casting to int.
> >
> > ---
> >
> > [2/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
> >
> > * Amend commit message.
> >
> > ---
> >
> > [3/13] bisect--helper: introduce new `write_in_file()` function
> >
> > * Use saved_errno variable.
> >
> > ---
> >
> > [5/13] bisect--helper: reimplement `bisect_autostart` shell function in C
> >
> > * Fix bug using empty_strvec instead of NULL in a `bisect_start()` call.
> >
> > ---
> >
> >
> > [6/13] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
> >  functions in C
> >
> > * Remove unused `no-checkout` variable.
> > * Move a comment to more appropriate place.
> >
> > ---
> >
> > .iriam Rubio (4):
> >   bisect--helper: BUG() in cmd_*() on invalid subcommand
> >   bisect--helper: use '-res' in 'cmd_bisect__helper' return
> >   bisect--helper: introduce new `write_in_file()` function
> >   bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'
> >
> > Pranit Bauva (9):
> >   bisect--helper: reimplement `bisect_autostart` shell function in C
> >   bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
> >     functions in C
> >   bisect--helper: finish porting `bisect_start()` to C
> >   bisect--helper: retire `--bisect-clean-state` subcommand
> >   bisect--helper: retire `--next-all` subcommand
> >   bisect--helper: reimplement `bisect_state` & `bisect_head` shell
> >     functions in C
> >   bisect--helper: retire `--check-expected-revs` subcommand
> >   bisect--helper: retire `--write-terms` subcommand
> >   bisect--helper: retire `--bisect-autostart` subcommand
> >
> >  bisect.c                 |  13 +-
> >  builtin/bisect--helper.c | 442 ++++++++++++++++++++++++++++++++-------
> >  git-bisect.sh            | 145 +------------
> >  3 files changed, 380 insertions(+), 220 deletions(-)
> >
> > --
> > 2.25.0
> >
> >

  reply	other threads:[~2020-09-23  7:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 10:50 Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 01/13] bisect--helper: BUG() in cmd_*() on invalid subcommand Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 03/13] bisect--helper: introduce new `write_in_file()` function Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 04/13] bisect--helper: reimplement `bisect_autostart` shell function in C Miriam Rubio
2020-09-03  5:50   ` Johannes Schindelin
2020-08-31 10:50 ` [PATCH v7 05/13] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()' Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 06/13] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C Miriam Rubio
2020-09-03  9:48   ` Johannes Schindelin
2020-08-31 10:50 ` [PATCH v7 07/13] bisect--helper: finish porting `bisect_start()` to C Miriam Rubio
2020-09-03  9:56   ` Johannes Schindelin
2020-08-31 10:50 ` [PATCH v7 08/13] bisect--helper: retire `--bisect-clean-state` subcommand Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 09/13] bisect--helper: retire `--next-all` subcommand Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 10/13] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C Miriam Rubio
2020-09-03 12:03   ` Johannes Schindelin
2020-08-31 10:50 ` [PATCH v7 11/13] bisect--helper: retire `--check-expected-revs` subcommand Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 12/13] bisect--helper: retire `--write-terms` subcommand Miriam Rubio
2020-08-31 10:50 ` [PATCH v7 13/13] bisect--helper: retire `--bisect-autostart` subcommand Miriam Rubio
2020-09-03 12:04 ` [PATCH v7 00/13] Finish converting git bisect to C part 2 Johannes Schindelin
2020-09-23  7:26   ` Miriam R. [this message]
2020-09-23 14:48     ` Johannes Schindelin
2020-09-23 21:23       ` Johannes Schindelin
2020-09-24  5:33         ` Christian Couder
2020-09-24  7:56           ` Johannes Schindelin
2020-09-24 10:46             ` Christian Couder
2020-09-24 12:53               ` Miriam R.
2020-09-24 12:56         ` Miriam R.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN7CjDDVp_i7dhpbAq5zrGW69nE6+SfivJQ-dembmu+WyqKiQQ@mail.gmail.com \
    --to=mirucam@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --subject='Re: [PATCH v7 00/13] Finish converting git bisect to C part 2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).