Re: Github Patch

[Pablo <pabloosabaterr@gmail.com>]

Zakariyah Ali (<zakariyahali100@gmail.com>) escribió:

The mail is empty but for the attached patch.

The patch should be sent inline in the email body, not as an attachment.
Please read Documentation/SubmittingPatches [1] and
Documentation/MyFirstContribution [2] about how to send patches.

Now, about the patch:

> From: alibaba0010 <zakariyahali100@gmail.com>
> Signed-off-by: alibaba0010 <zakariyahali100@gmail.com>

Your email says "Zakariyah Ali" but the From and Signed-off-by says
"alibaba0010. These should be consistent.
See Documentation/SubmittingPatches [1].

 "It is common, but not required, to use some form of your real name.
We realize that some contributors are not comfortable doing so or
prefer to contribute under a pseudonym or preferred name and we can
accept your patch either way, as long as the name and email you use
are distinctive, identifying, and not misleading."

> Replace old-style path checks using `test -f`, `test -d`,
> and `test ! -h` with dedicated test helper functions for
> improved test clarity and consistency.
>
> This modernization improves test script readability by using
> Git's dedicated test helpers: > - `test -f` → `test_path_is_file`
> - `test -d` → `test_path_is_dir`
> - `test ! -h && test -f` →
> `test_path_is_file_not_symlink`
> - `test ! -h && test -d` →
> `test_path_is_dir_not_symlink`

Try explaining why have you done this, why are these helpers better
than what was before rather than clarity and consistency, what do
these new helpers do to be considered valuable to refactor it.

> Found instances using: > git grep 'test -[efd]' t/ | grep 'test -[efd].*&&'

Even though it is mentioned on the microprojects to mention what have
you used to find the file, because it is only one file, including the
search command is not very useful. Drop it.

Given the date and that this seems a microproject I guess this is for
GSoC, you should add to the subject [GSoC PATCH] and CC your possible
co mentors.

I encourage you the same that it's being encourage for newcomers, read:

      https://lore.kernel.org/git/

There you'll find other microprojects similar to yours where you can learn from.

Code seems OK.

[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches
[2]: https://github.com/git/git/blob/master/Documentation/MyFirstContribution.adoc