git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Theodore Dubois <tbodt@google.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Alejandro Colomar <alx.manpages@gmail.com>,
	linux-man@vger.kernel.org, mtk.manpages@gmail.com,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] getpriority: Only getpriority translation the priority values
Date: Tue, 17 May 2022 10:02:36 -0700	[thread overview]
Message-ID: <CAN3rvwBWBPLB+Pm14S5Nb9LOV6ajhT8qMbwi5bBm1pK_8AgN5g@mail.gmail.com> (raw)
In-Reply-To: <CAN0heSper1O2ZdFq6RE=7znC0o+sFEsd8CBR3ckFtSoZu7Bzfw@mail.gmail.com>

Yep, I have diff.noprefix on.

~Theodore

On Sat, May 14, 2022 at 11:43 AM Martin Ågren <martin.agren@gmail.com> wrote:
>
> On Sat, 14 May 2022 at 17:11, Alejandro Colomar <alx.manpages@gmail.com> wrote:
> >
> > BTW, I had to manually edit the patch.
> > It's the second time I see this (I can't find the other one), your patch
> > didn't apply for the following reason: the a/ and b/ prefixes in the
> > file paths are missing.  Did you use git-format-patch(1) to produce the
> > patch?  Can you reproduce this?
> >
> > I CCd the git mailing list in case they know what's going on.
>
> Sounds like `git format-patch --no-prefix` at play. Or more likely, that
> the `diff.noprefix` config is on. I don't think it can be cancelled out
> by a `--no-no-prefix`, unfortunately. If a script is involved in running
> `git format-patch`, maybe it's not too tedious to make it do
>
>   git -c diff.noprefix=no format-patch ...
>
> to cancel the config. (If that config really does want to be on, that
> is.)
>
> That said, something like
>
>   git am -p0 ...
>
> should help on the receiving side, by way of skipping fewer path
> components when applying the patch.
>
> Martin

  parent reply	other threads:[~2022-05-17 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220510220821.1481801-1-tbodt@google.com>
2022-05-14 14:37 ` Alejandro Colomar
2022-05-14 15:00   ` Alejandro Colomar
2022-05-14 18:43   ` Martin Ågren
2022-05-14 21:18     ` Alejandro Colomar
2022-05-17 17:02     ` Theodore Dubois [this message]
2022-05-18 17:21       ` Perhaps we want {diff,log,format}.noprefix and friends? Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN3rvwBWBPLB+Pm14S5Nb9LOV6ajhT8qMbwi5bBm1pK_8AgN5g@mail.gmail.com \
    --to=tbodt@google.com \
    --cc=alx.manpages@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=mtk.manpages@gmail.com \
    --subject='Re: [PATCH] getpriority: Only getpriority translation the priority values' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).