From: "Martin Ågren" <martin.agren@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2] cmd-list.perl: fix identifying man sections
Date: Fri, 23 Sep 2022 13:42:37 +0200 [thread overview]
Message-ID: <CAN0heSrnN4Vjcj6KDG+DZkZ7_GWz5dex2Qq0To6CGVH7_zux4Q@mail.gmail.com> (raw)
In-Reply-To: <220923.86fsgi4gl6.gmgdl@evledraar.gmail.com>
On Fri, 23 Sept 2022 at 10:53, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>
> Thanks for the quick turn-around, this looks good to me in this form.
Thanks for reviewing.
> Now, having written and looked at this with fresh eyes this would be an
> even better & more logical thing to do:
> open I, '<', "$name.txt" or die "No such file $name.txt";
> while (<I>) {
> - if (/^(?:git|scalar)[a-z0-9-]*\(([0-9])\)$/) {
> + if (/^\Q$name\E\(([0-9])\)$/) {
> $mansection = $1;
> next;
> }
Right, we know what we want there, so this does look reasonable.
> Anyway, this is more than good enough for now, thanks! There's also much
> bigger issues with the script, and we can leave that all aside from now
> (e.g. if it dies the Makefile doesn't report an error, ouch!).
Martin
next prev parent reply other threads:[~2022-09-23 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 7:03 [PATCH] cmd-list.perl: fix identifying man sections Martin Ågren
2022-09-23 7:38 ` Ævar Arnfjörð Bjarmason
2022-09-23 8:07 ` [PATCH v2] " Martin Ågren
2022-09-23 8:37 ` Ævar Arnfjörð Bjarmason
2022-09-23 11:42 ` Martin Ågren [this message]
2022-09-23 17:01 ` Junio C Hamano
2022-09-23 22:07 ` [PATCH] " Jeff King
2022-09-26 7:16 ` Martin Ågren
2022-09-26 17:06 ` Junio C Hamano
2022-09-26 13:35 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSrnN4Vjcj6KDG+DZkZ7_GWz5dex2Qq0To6CGVH7_zux4Q@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).