git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Martin Ågren" <martin.agren@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] manpage-bold-literal.xsl: provide namespaced template for "d:literal"
Date: Thu, 31 Oct 2019 07:21:32 +0100	[thread overview]
Message-ID: <CAN0heSrY9jOrRmt_ViJZ8Yv96XPNh4atArxqNO1=Tr57wdt0Zw@mail.gmail.com> (raw)
In-Reply-To: <20191031023150.mdbj74sthrftnqie@camp.crustytoothpaste.net>

On Thu, 31 Oct 2019 at 03:32, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> On 2019-10-30 at 20:41:04, Martin Ågren wrote:
> >  I'm pretty sure about the background here, but I'm not at all sure
> >  that this is the prettiest or correctest fix.
>
> This fix is correct.  Thanks for sending a patch for this, and sorry
> about regressing our bolding behavior.

Thanks! And no worries. I should have spotted this sooner.

> If you want to avoid duplication, you can write the existing template as
> follows:
>
>   <xsl:template match="literal|d:literal">
>
> That will match both literal and d:literal tags.  You still need the
> namespace declaration you added, of course.

Thanks. I use this for v2.

Martin

  reply	other threads:[~2019-10-31  6:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 20:41 [PATCH] manpage-bold-literal.xsl: provide namespaced template for "d:literal" Martin Ågren
2019-10-30 21:24 ` Jeff King
2019-10-31  6:19   ` Martin Ågren
2019-10-31  2:31 ` brian m. carlson
2019-10-31  6:21   ` Martin Ågren [this message]
2019-11-02  5:45     ` Junio C Hamano
2019-10-31  6:22 ` [PATCH v2] manpage-bold-literal.xsl: match for namespaced "d:literal" in template Martin Ågren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN0heSrY9jOrRmt_ViJZ8Yv96XPNh4atArxqNO1=Tr57wdt0Zw@mail.gmail.com' \
    --to=martin.agren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).