From: "Martin Ågren" <martin.agren@gmail.com>
To: Christian Ludwig <chrissicool@googlemail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Christian Ludwig <chrissicool@gmail.com>
Subject: Re: [PATCH v2 2/2] send-email: Support separate Reply-To address
Date: Thu, 18 Jan 2018 12:00:04 +0100 [thread overview]
Message-ID: <CAN0heSqxmLoh33i65JPhyQbmPaAcJcwrTCO+ZD4eb+qh8Pf8+w@mail.gmail.com> (raw)
In-Reply-To: <20180117180801.31049-2-chrissicool@gmail.com>
On 17 January 2018 at 19:08, Christian Ludwig
<chrissicool@googlemail.com> wrote:
> In some projects contributions from groups are only accepted from a
> common group email address. But every individual may want to recieve
> replies to her own personal address. That's what we have 'Reply-To'
> headers for in SMTP.
s/recieve/receive/
> Introduce an optional '--reply-to' command line option. Unfortunately
> the $reply_to variable name was already taken for the 'In-Reply-To'
> header field. To reduce code churn, use $reply_address as variable
> name instead.
"To reduce ..." no longer describes the patch, since v2 actually
performs that refactoring in patch 1/2. "Unfortunately ..." is
correct, but seems less relevant now. Except:
I suppose that a non-git.git patch which uses $reply_to could start
misbehaving now that this series changes the meaning of that variable.
Just thinking out loud, it could make some sense to take patch 1/2 for
sanity, but to then *not* re-use $reply_to for a new purpose, but to
actually take your v1-patch as 2/2. Or, this potential problem can
perhaps be ignored (except in the commit message?)..
> Signed-off-by: Christian Ludwig <chrissicool@gmail.com>
"From:" and "Signed-off-by:" are different. Not sure if that's ok.
Martin
next prev parent reply other threads:[~2018-01-18 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:08 [PATCH v2 1/2] send-email: Rename variable for clarity Christian Ludwig
2018-01-17 18:08 ` [PATCH v2 2/2] send-email: Support separate Reply-To address Christian Ludwig
2018-01-17 21:02 ` Junio C Hamano
2018-01-17 22:06 ` Ævar Arnfjörð Bjarmason
2018-01-18 11:00 ` Martin Ågren [this message]
2018-01-17 19:05 ` [PATCH v2 1/2] send-email: Rename variable for clarity Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSqxmLoh33i65JPhyQbmPaAcJcwrTCO+ZD4eb+qh8Pf8+w@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=chrissicool@gmail.com \
--cc=chrissicool@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).