From: "Martin Ågren" <martin.agren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Joey Hess <id@joeyh.name>, Git Mailing List <git@vger.kernel.org>,
Tao Klerks <tao@klerks.biz>,
Derrick Stolee <derrickstolee@github.com>,
Victoria Dye <vdye@github.com>
Subject: Re: [PATCH] read-cache: make `do_read_index()` always set up `istate->repo`
Date: Sat, 23 Jul 2022 00:00:11 +0200 [thread overview]
Message-ID: <CAN0heSqQLhM=mGhOVKyR+fqM3hm3na+dZhx+HPnq+UJFaGudVA@mail.gmail.com> (raw)
In-Reply-To: <xmqqtu78bz25.fsf@gitster.g>
On Fri, 22 Jul 2022 at 23:46, Junio C Hamano <gitster@pobox.com> wrote:
>
> Martin Ågren <martin.agren@gmail.com> writes:
>
> > +test_expect_success 'empty repo (no index) and core.untrackedCache' '
> > + git init emptyrepo &&
> > + cd emptyrepo/ &&
> > + git -c core.untrackedCache=true write-tree
> > +'
>
> I'll tweak this with "-C emptyrepo" so that future developers do not
> have to get bitten when they add more tests to this script.
Yikes. I should have known better. Thanks for catching that. If a v2 is
needed for any reason, I'll include this change.
Martin
prev parent reply other threads:[~2022-07-22 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 17:24 git write-tree segfault with core.untrackedCache true and nonexistent index Joey Hess
2022-07-22 19:25 ` Martin Ågren
2022-07-22 19:41 ` Junio C Hamano
2022-07-22 21:22 ` [PATCH] read-cache: make `do_read_index()` always set up `istate->repo` Martin Ågren
2022-07-22 21:46 ` Junio C Hamano
2022-07-22 22:00 ` Martin Ågren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSqQLhM=mGhOVKyR+fqM3hm3na+dZhx+HPnq+UJFaGudVA@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=id@joeyh.name \
--cc=tao@klerks.biz \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).