From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 515BB1F9FD for ; Sun, 28 Feb 2021 20:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbhB1UB4 (ORCPT ); Sun, 28 Feb 2021 15:01:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhB1UBz (ORCPT ); Sun, 28 Feb 2021 15:01:55 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E757C061786 for ; Sun, 28 Feb 2021 12:01:15 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id b15so9674215pjb.0 for ; Sun, 28 Feb 2021 12:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AhwAySjtesc1FQBwe/tDBbtrSd2VxUUFmUaUiD2d5js=; b=SkLsTIEmv7L6zqXUKZ3m66oeh7QB+f/OT+yOXXxd+fELXifeOjwjsdaxtMmw+mG8w5 1Qv7V1g/AuzhgB8OfmqP/5fP50L+IvwyndOF+X7suPxnzeYsygutYnya5SUuPq34G5B6 7A6ejV80j3DOV3pR8jCOrPdJD5QM3RBwBRU2wuOaX+EFyx8oKzX5AfeftUT0bRK6FwwP SuHYG0CmobqU1CriwPjRdKo7LcNFGxlIOSaU+BfJEpq3XbqLWHbl/SuGMgLrdYtJ/xpK kWlsg2rAAKgkuUVvTiJt7VcUCDVO80Bd9h+SjlgLRe9gDFPhUJoB/gW0VvXucZ5JVn2D ShYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AhwAySjtesc1FQBwe/tDBbtrSd2VxUUFmUaUiD2d5js=; b=QCuRv8GiccXHU7GMRn8UUi2hHhwTc7pyjrPqj0QrWtNh2SrAVpMs4qFssHam5lRodc gHM0KvZd5SyA0K8izI1dzqNUvXkXQBY5nJ6lQKk+Rz0/cySXFPBiZ42YgjbJaI+yTaka dPxv6yGvkLZ1AbhllB3IvcYPcV5RvF3L449d9m9Co8Z9zUkd5y1C+aW5nFku1ZB2Nb5C H89ZoV6WqJeq7s82FYmjwtYssd/MVtr5bKMleb/QvJ+78FN+277+jSYYW7ADJRTbKTDq ypOAg5ia1N7YwsLSHmZrxU9UMxqcyjWLjC2Kf77Nr0f5Z1taYV7AswGdkCJaApqf+R5m gR/Q== X-Gm-Message-State: AOAM5305rqkDUi/JXoy8JxJRmVfvxNkioHQk5q2EKfqElMxoJC+ud6ud ayCtkaBDDvHi2qXvABfXWx5/6WjpS8t0YhekEvg= X-Google-Smtp-Source: ABdhPJybtXQMGGDRHpiFtxK9cJ8jZfHatfWb5a9vW/aCTUJ6/fhFmMc4VjIHqhkhTZekJS/K8HPfEQUYOfvooHqHQoo= X-Received: by 2002:a17:90b:34c:: with SMTP id fh12mr13545262pjb.137.1614542474453; Sun, 28 Feb 2021 12:01:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Martin_=C3=85gren?= Date: Sun, 28 Feb 2021 21:01:03 +0100 Message-ID: Subject: Re: [PATCH v2] convert: fail gracefully upon missing clean cmd on required filter To: Matheus Tavares Cc: Git Mailing List , prohaska@zib.de, Junio C Hamano Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, 26 Feb 2021 at 17:24, Matheus Tavares wrote: > This assertion is not really necessary, as the apply_filter() call below > it already performs the same check. And when this condition is not met, > - assert(ca.drv->clean || ca.drv->process); FWIW, this LGTM. > + test_i18ngrep "fatal: test.ac: clean filter .absentclean. failed" stderr > + test_i18ngrep "fatal: test.as: smudge filter absentsmudge failed" stderr (Funny how these two error messages differ in quoting. That's obviously not anything your patch needs to fix.) Martin