From: "Martin Ågren" <martin.agren@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
kumbayo84@arcor.de, pc44800@gmail.com
Subject: Re: [PATCH] submodule deinit: handle non existing pathspecs gracefully
Date: Wed, 28 Mar 2018 06:09:00 +0200 [thread overview]
Message-ID: <CAN0heSpG9zq1bFawid7MoaVQ--WXPv=cXduhjjV=Q3kcK2TMeQ@mail.gmail.com> (raw)
In-Reply-To: <20180327232824.112539-1-sbeller@google.com>
On 28 March 2018 at 01:28, Stefan Beller <sbeller@google.com> wrote:
> This fixes a regression introduced in 22e612731b5 (submodule: port
s/22/2/
> submodule subcommand 'deinit' from shell to C, 2018-01-15), when handling
> pathspecs that do not exist gracefully. This restores the historic behavior
> of reporting the pathspec as unknown and returning instead of reporting a
> bug.
next prev parent reply other threads:[~2018-03-28 4:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 19:48 git submodule deinit resulting in BUG: builtin/submodule--helper.c:1045: module_list_compute should not choke on empty pathspec Peter Oberndorfer
2018-03-27 22:56 ` Stefan Beller
2018-03-27 23:28 ` [PATCH] submodule deinit: handle non existing pathspecs gracefully Stefan Beller
2018-03-28 4:09 ` Martin Ågren [this message]
2018-03-28 5:06 ` Junio C Hamano
2018-03-28 19:37 ` git submodule deinit resulting in BUG: builtin/submodule--helper.c:1045: module_list_compute should not choke on empty pathspec Peter Oberndorfer
2018-03-28 21:19 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSpG9zq1bFawid7MoaVQ--WXPv=cXduhjjV=Q3kcK2TMeQ@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kumbayo84@arcor.de \
--cc=pc44800@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).