From: "Martin Ågren" <martin.agren@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 4/5] lock_file: make function-local locks non-static
Date: Sun, 6 May 2018 21:32:00 +0200 [thread overview]
Message-ID: <CAN0heSpA5H7Gwwx0TEY9=iFJrgKb0SPXqKOwHK=4NxPYoGjZ7A@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8Btuc2J4aCTymkvLYyMV5zJrdMUdtV5NDnPqXOjsTVw4w@mail.gmail.com>
On 6 May 2018 at 19:42, Duy Nguyen <pclouds@gmail.com> wrote:
> On Sun, May 6, 2018 at 7:26 PM, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Sun, May 6, 2018 at 4:10 PM, Martin Ågren <martin.agren@gmail.com> wrote:
>>> These `struct lock_file`s are local to their respective functions and we
>>> can drop their staticness.
>>> - static struct lock_file lock;
>>> + struct lock_file lock = LOCK_INIT;
>>
>> Is it really safe to do this? I vaguely remember something about
>> (global) linked list and signal handling which could trigger any time
>> and probably at atexit() time too (i.e. die()). You don't want to
>> depend on stack-based variables in that case.
>
> So I dug in a bit more about this. The original implementation does
> not allow stack-based lock files at all in 415e96c8b7 ([PATCH]
> Implement git-checkout-cache -u to update stat information in the
> cache. - 2005-05-15). The situation has changed since 422a21c6a0
> (tempfile: remove deactivated list entries - 2017-09-05). At the end
> of that second commit, Jeff mentioned "We can clean them up
> individually" which I guess is what these patches do. Though I do not
> know if we need to make sure to call "release" function or something/
> Either way you need more explanation and assurance than just "we can
> drop their staticness" in the commit mesage.
Thank you Duy for your comments. How about I write the commit message
like so:
After 076aa2cbd (tempfile: auto-allocate tempfiles on heap, 2017-09-05),
we can have lockfiles on the stack. These `struct lock_file`s are local
to their respective functions and we can drop their staticness.
Each of these users either commits or rolls back the lock in every
codepath, with these possible exceptions:
* We bail using a call to `die()` or `exit()`. The lock will be
cleaned up automatically.
* We return early from a function `cmd_foo()` in builtin/, i.e., we
are just about to exit. The lock will be cleaned up automatically.
If I have missed some codepath where we do not exit, yet leave a locked
lock around, that was so also before this patch. If we would later
re-enter the same function, then before this patch, we would be retaking
a lock for the very same `struct lock_file`, which feels awkward, but to
the best of my reading has well-defined behavior. Whereas after this
patch, we would attempt to take the lock with a completely fresh `struct
lock_file`. In both cases, the result would simply be that the lock can
not be taken, which is a situation we already handle.
next prev parent reply other threads:[~2018-05-06 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 14:10 [PATCH 4/5] lock_file: make function-local locks non-static Martin Ågren
2018-05-06 17:26 ` Duy Nguyen
2018-05-06 17:42 ` Duy Nguyen
2018-05-06 19:32 ` Martin Ågren [this message]
2018-05-07 15:24 ` Duy Nguyen
2018-05-07 21:19 ` Martin Ågren
2018-05-08 18:18 ` Jeff King
2018-05-09 16:19 ` Duy Nguyen
2018-05-09 17:07 ` Martin Ågren
2018-05-10 4:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN0heSpA5H7Gwwx0TEY9=iFJrgKb0SPXqKOwHK=4NxPYoGjZ7A@mail.gmail.com' \
--to=martin.agren@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).