From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7C38D1F4B4 for ; Sat, 12 Sep 2020 14:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725869AbgILOCl (ORCPT ); Sat, 12 Sep 2020 10:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgILOC2 (ORCPT ); Sat, 12 Sep 2020 10:02:28 -0400 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8EA5C061573 for ; Sat, 12 Sep 2020 07:02:27 -0700 (PDT) Received: by mail-vs1-xe43.google.com with SMTP id y194so7002195vsc.4 for ; Sat, 12 Sep 2020 07:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=uj+XxiZR9t/aHpzvNExpHuDpnTRmUHptKNF8dM2/sSo=; b=QEIymF36zxleuCDclXU7Z+1VOYMT/5m5LF2BmvLTcRRGYvl5mQpSC/QnSPQDQC/BwE HSQSlEsWSGhrx+zdD2Z7y9aFVTxm2Mzsv0z2Sck8uLo2aTrYmKqXLeWwGJrGvjUmrKfk paQdh1ZUgFwHMf+WKsApp5Xn13D1wx3bofVlrVZ3j3PBewD6pqdEjQqP7IlJCHtjhKKT o6ZljZu6RGrQ1nTS9CCOeTYyYawELkg/WPx6h2hmYMjGG8FXP9hCUJoXOP4ItcjuZGsI lVJU1j1R4+rgyS+CDRBf/4hq5m8N3+DngIlJtDlgqorO+m8bcw0coiDH50goM44NHNCX pFLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uj+XxiZR9t/aHpzvNExpHuDpnTRmUHptKNF8dM2/sSo=; b=ic8IfcuIeeRN5cMSC2wuMs3J4wwmrPWPM/NHprzH85nNSual3bbtPsIf6wQs5Q7Ybh mNICDmfhPgOWS2vliKXp+emGddWVdUFCXgoyI4c53Lt8uMfMFKEpHhN3TeEs1VgPBW2y 2bUAoA3UKh0FLvtwwZWdfOmq6UHPOA8Q0EfFWiS3yxPEVOQHq+MEEcf2oDAQeh+qSwEs IaKU0mXCu7JDK5TK80OmtIgIoHfwLZ90DGgWudO2cd+BBdw921Xb0Ino0dbgsc5Q5jWD GDYf/eRFEmgT+7SQma7WQoBL1yL17M2u32yVenjs12iiu3rr5AmjvBKpnQkgXWKINKMo 5tQQ== X-Gm-Message-State: AOAM530FJzckFZAXz05tBkjHfo9/tc6Lz/pH47EDtImpu7hqdprfoe+1 dNCoLrmgS65PWOf8iYlgVmHXG4gq+SRBCuHnqtI= X-Google-Smtp-Source: ABdhPJycZxOqL2Oq12+CkFMYvUTE7YXC93qNIslF9nRK2rYLsCcB26v5nCF7tmTweNl+MqUuE0ovBDBaynTvSnHv0+I= X-Received: by 2002:a67:2245:: with SMTP id i66mr3732528vsi.1.1599919346088; Sat, 12 Sep 2020 07:02:26 -0700 (PDT) MIME-Version: 1.0 References: <58a2469cc18839e57b45f687b6e484d69161a34c.1599762679.git.martin.agren@gmail.com> In-Reply-To: From: =?UTF-8?Q?Martin_=C3=85gren?= Date: Sat, 12 Sep 2020 16:02:13 +0200 Message-ID: Subject: Re: [PATCH 4/8] worktree: drop useless call to strbuf_reset To: Eric Sunshine Cc: Git List , Junio C Hamano Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, 10 Sep 2020 at 21:49, Eric Sunshine wrote= : > > On Thu, Sep 10, 2020 at 3:40 PM Martin =C3=85gren wrote: > > That's not to say this optimization won't ever be useful, of course. I > > also begin to hope that no caller keeps their returned pointer around > > for long. It only seems to be used from `other_ref_heads()` and that > > looks ok. If we do want this strbuf reuse, maybe that function could > > just keep its own strbuf and reuse it (not necessarily having it be > > static) and learn not to call `worktree_ref(wt, "HEAD")` twice. > > Yep, I wouldn't be unhappy to see worktree_ref() disappear altogether. > There are no external callers and it would be easy enough to retrofit > the lone internal caller to use the safer strbuf_worktree_ref() > anyhow. Plus, both calls to worktree_ref() in other_head_refs() invoke > it with the exact same arguments, `worktree_ref(wt, "HEAD")`, which > makes one wonder if it need be called twice at all in that particular > scenario. I'll look at this hopefully tomorrow. Thanks for all your comments. Martin