From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jeff King <peff@peff.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] rev-parse: don't trim bisect refnames
Date: Wed, 6 Sep 2017 17:09:16 +0200 [thread overview]
Message-ID: <CAMy9T_FQHei2XgidRqcBPabKCGq2g282KgYDhe-e9XqSjJE1gw@mail.gmail.com> (raw)
In-Reply-To: <20170906115310.kxgjrnmrehm5m32q@sigill.intra.peff.net>
On Wed, Sep 6, 2017 at 1:53 PM, Jeff King <peff@peff.net> wrote:
> [...]
> Subject: [PATCH] rev-parse: don't trim bisect refnames
>
> Using for_each_ref_in() with a full refname has always been
> a questionable practice, but it became an error with
> b9c8e7f2fb (prefix_ref_iterator: don't trim too much,
> 2017-05-22), making "git rev-parse --bisect" pretty reliably
> show a BUG.
>
> Commit 03df567fbf (for_each_bisect_ref(): don't trim
> refnames, 2017-06-18) fixed this case for revision.c, but
> rev-parse handles this option on its own. We can use the
> same solution here (and piggy-back on its test).
It looks good to me.
Michael
next prev parent reply other threads:[~2017-09-06 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 21:39 BUG: attempt to trim too many characters Linus Torvalds
2017-09-05 21:50 ` Jeff King
2017-09-05 21:55 ` Linus Torvalds
2017-09-05 22:03 ` Jeff King
2017-09-05 22:13 ` Linus Torvalds
2017-09-06 11:53 ` [PATCH] rev-parse: don't trim bisect refnames Jeff King
2017-09-06 15:09 ` Michael Haggerty [this message]
2017-09-13 4:29 ` BUG: attempt to trim too many characters Linus Torvalds
2017-09-13 11:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMy9T_FQHei2XgidRqcBPabKCGq2g282KgYDhe-e9XqSjJE1gw@mail.gmail.com \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).