From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Jeff King <peff@peff.net>
Cc: Dennis Kaarsemaker <dennis@kaarsemaker.net>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer
Date: Mon, 25 May 2015 22:07:50 -0400 [thread overview]
Message-ID: <CAMwyc-Tn+Sw67z9zTPsPU7SQP7PDzJhoJn30utQ0OWhKe_xbuA@mail.gmail.com> (raw)
In-Reply-To: <20150520073709.GC9818@peff.net>
On 20 May 2015 at 03:37, Jeff King <peff@peff.net> wrote:
> + /* partial read from read_in_full means we hit EOF */
> + len += cnt;
> + if (len < alloc) {
> + *out = buf;
> + warning("request size was %lu", (unsigned long)len);
> + return len;
> + }
Jeff:
This patch appears to work well -- the only complaint I have is that I
now have "warning: request size was NNN" all over my error logs. :) Is
it supposed to convey an actual warning message, or is it merely a
debug statement?
Best,
--
Konstantin Ryabitsev
Sr. Systems Administrator
Linux Foundation Collab Projects
541-224-6067
Montréal, Québec
next prev parent reply other threads:[~2015-05-26 2:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 21:04 Clone hangs when done over http with --reference Konstantin Ryabitsev
2015-05-14 0:47 ` Jeff King
2015-05-14 1:02 ` [PATCH] http-backend: fix die recursion with custom handler Jeff King
2015-05-15 6:20 ` Jeff King
2015-05-14 17:08 ` Clone hangs when done over http with --reference Konstantin Ryabitsev
2015-05-14 19:52 ` Jeff King
2015-05-15 6:29 ` [PATCH 0/2] fix http deadlock on giant ref negotiations Jeff King
2015-05-15 6:29 ` [PATCH 1/2] http-backend: fix die recursion with custom handler Jeff King
2015-05-15 6:33 ` [PATCH 2/2] http-backend: spool ref negotiation requests to buffer Jeff King
2015-05-15 18:22 ` Junio C Hamano
2015-05-15 18:28 ` Konstantin Ryabitsev
2015-05-20 7:35 ` [PATCH v2 0/3] fix http deadlock on giant ref negotiations Jeff King
2015-05-20 7:36 ` [PATCH v2 1/3] http-backend: fix die recursion with custom handler Jeff King
2015-05-20 7:36 ` [PATCH v2 2/3] t5551: factor out tag creation Jeff King
2015-05-20 7:37 ` [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer Jeff King
2015-05-26 2:07 ` Konstantin Ryabitsev [this message]
2015-05-26 2:24 ` Jeff King
2015-05-26 3:43 ` Junio C Hamano
2015-05-15 19:16 ` [PATCH 2/2] " Jeff King
2015-05-15 7:41 ` [PATCH 0/2] fix http deadlock on giant ref negotiations Dennis Kaarsemaker
2015-05-15 8:38 ` Jeff King
2015-05-15 8:44 ` Dennis Kaarsemaker
2015-05-15 8:53 ` Jeff King
2015-05-15 9:11 ` Dennis Kaarsemaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMwyc-Tn+Sw67z9zTPsPU7SQP7PDzJhoJn30utQ0OWhKe_xbuA@mail.gmail.com \
--to=konstantin@linuxfoundation.org \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).