git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: hIpPy <hippy2981@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: Git makes a merge commit but as a normal (non-merge) commit
Date: Fri, 18 Aug 2017 15:35:52 -0700	[thread overview]
Message-ID: <CAM_JFCzZWfyUiFVrYOztdJD8iSYvYUavbzKOX2bxDV0_hMz7Eg@mail.gmail.com> (raw)

While merging if I do certain actions then the merge commit is made
with the merge message but as a normal (non-merge) commit.

Repro steps:
- Set GIT_MERGE_AUTOEDIT=yes (set other than "no") in .bashrc
- Make a merge commit with no conflicts.
  (external text editor shows the generated merge message)
- Focus on Git Bash and Ctrl-C.
- Commit (git commit).

Actual behavior:
Git makes a normal (non-merge) commit (squash merge) but with the
merge commit message.

It looks like a bug to me. This is very confusing later on as the repo
topology would show that the branch is not merged in and there is not
an easy way to find out when the merge was made.

Expected behavior:
Git should stay in a MERGING state. The user can choose to either
abort the merge or continue the merge (git merge --continue OR git
commit).

This does not happen in case of conflicts (at least I'm not able to
repro). I get a (master|MERGING) prompt till I resolve the conflicts
and commit, which goes through correctly as a merge commit.

Environment:
$ git version
git version 2.14.0.windows.2
$ bash --version
GNU bash, version 4.4.12(1)-release (x86_64-pc-msys)

Thanks,
RM

             reply	other threads:[~2017-08-18 22:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 22:35 hIpPy [this message]
2017-08-21 10:03 ` Git makes a merge commit but as a normal (non-merge) commit Michael J Gruber
2017-08-21 10:06   ` [PATCH] merge: save merge state earlier Michael J Gruber
2017-08-21 12:53     ` [PATCH v2 0/3] Keep merge during kills Michael J Gruber
2017-08-21 12:53       ` [PATCH v2 1/3] Documentation/git-merge: explain --continue Michael J Gruber
2017-08-21 16:43         ` Martin Ågren
2017-08-22  9:26           ` Michael J Gruber
2017-08-22 10:06             ` Martin Ågren
2017-08-22 15:24               ` hIpPy
2017-08-22 16:11                 ` Junio C Hamano
2017-08-23 12:10                   ` [PATCH v3 0/4] Keep merge during kills Michael J Gruber
2017-08-23 12:10                     ` [PATCH v3 1/4] Documentation/git-merge: explain --continue Michael J Gruber
2017-08-23 12:10                     ` [PATCH v3 2/4] merge: clarify call chain Michael J Gruber
2017-08-23 12:10                     ` [PATCH v3 3/4] merge: split write_merge_state in two Michael J Gruber
2017-08-23 12:10                     ` [PATCH v3 4/4] merge: save merge state earlier Michael J Gruber
2017-08-22  0:20         ` [PATCH v2 1/3] Documentation/git-merge: explain --continue Junio C Hamano
2017-08-21 12:53       ` [PATCH v2 2/3] merge: split write_merge_state in two Michael J Gruber
2017-08-22  0:20         ` Junio C Hamano
2017-08-21 12:53       ` [PATCH v2 3/3] merge: save merge state earlier Michael J Gruber
2017-08-22  0:38         ` Junio C Hamano
2017-08-22  9:36           ` Michael J Gruber
2017-08-22 16:03             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_JFCzZWfyUiFVrYOztdJD8iSYvYUavbzKOX2bxDV0_hMz7Eg@mail.gmail.com \
    --to=hippy2981@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).