From: David <bouncingcats@gmail.com>
To: git list <git@vger.kernel.org>
Subject: Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”
Date: Sun, 15 Sep 2019 01:57:31 +1000 [thread overview]
Message-ID: <CAMPXz=pNFpg7B0uYCBWvKwOqG8VZWfOxvf+8mZ9qc7w6DkF=+w@mail.gmail.com> (raw)
In-Reply-To: <3fac912d-9e3c-bf19-e1e5-2691a835b151@xiplink.com>
On Sat, 14 Sep 2019 at 08:07, Marc Branchaud <marcnarc@xiplink.com> wrote:
> On 2019-09-13 10:32 a.m., Pratyush Yadav wrote:
> > On 13/09/19 12:24PM, Allan Ford wrote:
> >> Not a bug, but a suggestion consideration for “Git Gui”
> >> Can a double click on the file name in the “unstaged” area move the
> >> item to “staged changes” .. (rather than having to click on the small
> >> icon to the left of the file name?)
> > It has been something on my radar for some time. Shouldn't be something
> > too difficult to do.
> > While I like the idea in general, I have a question that I'd like to ask
> > other git-gui users:
Thank you for asking.
> I've always felt this was a bit of user-experience failure on git-gui's
> part. Single-click should not behave differently just because you click
> the icon.
> I've seen many new git-gui users find this (mildly) confusing.
I acknowledge that consistency is an important aspect of GUI design.
Particularly for new and/or low-competency users. But surely
efficiency must also be valued too. Repetitive strain injury is not
nice. I have some days where I have hundreds or possibly even
thousands of such single clicksto stage and unstage items. Currently
it is possible to review and accumulate them efficiently due to how
that pane responds.
And this seems a very small aspect to learn. if a person is so
"confused" by such a small thing to learn, I wonder what hope they
would have to comprehend git itself.
> I'd be happy if the click behavior was consistent across the entire
> row: single-click to select,
> double-click to stage/unstage
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Please, no.
I can't say it strongly enough. Please do not change stage/unstage
to require double-click. This would be most unwelcome here, unless it
comes with a configuration option to preserve the old behaviour.
Maybe the actual problem is that the present icon (perhaps surprisingly)
has the behaviour of a blank check-box that relocates. I don't wish for
any change, but if the desire for change is irresistable then the
simplest solution is for the icon (that appears to the left of filenames
in the unstaged pane) to be replaced with blank check box that
behaves exactly as the current icon does. That is:
When clicked, it becomes a checked-box alongside the filename in
the staged area. And if that staged-checked-box is clicked, it reverts to
an unchecked-box (instead of the icon) in the unstaged pane.
next prev parent reply other threads:[~2019-09-14 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 2:54 Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes” Allan Ford
2019-09-13 14:32 ` Pratyush Yadav
2019-09-13 20:27 ` Bert Wesarg
2019-09-13 21:06 ` Pratyush Yadav
2019-09-14 16:07 ` David
2019-09-14 19:08 ` Pratyush Yadav
2019-09-15 3:41 ` David
2019-09-16 17:49 ` Pratyush Yadav
2019-09-13 21:53 ` Marc Branchaud
2019-09-14 15:57 ` David [this message]
2019-09-14 21:23 ` Pratyush Yadav
2019-09-15 3:42 ` David
2019-09-14 7:24 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMPXz=pNFpg7B0uYCBWvKwOqG8VZWfOxvf+8mZ9qc7w6DkF=+w@mail.gmail.com' \
--to=bouncingcats@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).