git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: David <bouncingcats@gmail.com>
To: git list <git@vger.kernel.org>
Subject: Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”
Date: Sun, 15 Sep 2019 13:42:53 +1000	[thread overview]
Message-ID: <CAMPXz=o_kxpKicfV6nurkU7j4nHXka2Xk1B2Qeosrjn-UB+btQ@mail.gmail.com> (raw)
In-Reply-To: <20190914212357.cg7t5cufqwd3wj66@yadavpratyush.com>

On Sun, 15 Sep 2019 at 07:24, Pratyush Yadav <me@yadavpratyush.com> wrote:
> On 15/09/19 01:57AM, David wrote:

> > I can't say it strongly enough. Please do not change stage/unstage
> > to require double-click. This would be most unwelcome here, unless it
> > comes with a configuration option to preserve the old behaviour.
> >
> > Maybe the actual problem is that the present icon (perhaps surprisingly)
> > has the behaviour of a blank check-box that relocates. I don't wish for
> > any change, but if the desire for change is irresistable then the
> > simplest solution is for the icon (that appears to the left of filenames
> > in the unstaged pane) to be replaced with blank check box that
> > behaves exactly as the current icon does. That is:
> > When clicked, it becomes a checked-box alongside the filename in
> > the staged area. And if that staged-checked-box is clicked, it reverts to
> > an unchecked-box (instead of the icon) in the unstaged pane.
>
> Hmm, I like this idea. But right now the icons also show the state of
> the file (modified, added, etc.), so if you switch them to a checkbox
> you lose that information. Are you and other people willing to lose that
> information.
>
> Though I've personally never been a huge fan of those icons. They never
> really managed to convey too much meaning to me. So I won't mind
> changing them to something like the single-letter git-status status
> flags. This also gives us a bit of consistency with git-status's flags,
> so people used to the command line will recognize them instantly.
> Thoughts?

Ah, this is hilarious and embarassing. It confirms what I wrote in my other
message:
  Some days I have good ideas, other days my ideas
  have flaws that I missed, so I like to discuss first.

ie, Some days I'm an idiot! I completely forgot about those other icons!
I like them! In particular, the one that indicates removed files, and
the special one that indicates when a committed file has been replaced
by a symlink, or vice versa, are very valuable to me.

I don't really want any of this to change. I only suggested the change
because I didn't want to appear totally negative. So I tried to come up
with an alternative suggestion. But it was a dumb proposal.

So dumb in fact that I'm now arguing against it :(
Oh well :D
Anyway, I'm a fan of those icons, please don't change them.

  reply	other threads:[~2019-09-15  3:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  2:54 Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes” Allan Ford
2019-09-13 14:32 ` Pratyush Yadav
2019-09-13 20:27   ` Bert Wesarg
2019-09-13 21:06     ` Pratyush Yadav
2019-09-14 16:07     ` David
2019-09-14 19:08       ` Pratyush Yadav
2019-09-15  3:41         ` David
2019-09-16 17:49           ` Pratyush Yadav
2019-09-13 21:53   ` Marc Branchaud
2019-09-14 15:57     ` David
2019-09-14 21:23       ` Pratyush Yadav
2019-09-15  3:42         ` David [this message]
2019-09-14  7:24   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMPXz=o_kxpKicfV6nurkU7j4nHXka2Xk1B2Qeosrjn-UB+btQ@mail.gmail.com' \
    --to=bouncingcats@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).