From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Contreras Subject: Re: [PATCH 2/2] Move sequencer to builtin Date: Sun, 9 Jun 2013 13:11:16 -0500 Message-ID: References: <20130609043444.GA561@sigill.intra.peff.net> <20130609175554.GA810@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Jeff King , Duy Nguyen , Git Mailing List , Junio C Hamano , Brandon Casey , Jonathan Nieder To: Ramkumar Ramachandra X-From: git-owner@vger.kernel.org Sun Jun 09 20:11:28 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ulk5K-0000iJ-T9 for gcvg-git-2@plane.gmane.org; Sun, 09 Jun 2013 20:11:23 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000Ab3FISLT (ORCPT ); Sun, 9 Jun 2013 14:11:19 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:38674 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667Ab3FISLS (ORCPT ); Sun, 9 Jun 2013 14:11:18 -0400 Received: by mail-lb0-f179.google.com with SMTP id w20so5639472lbh.38 for ; Sun, 09 Jun 2013 11:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=IP5oxk4NzUSBZkSmBPzaJ7tBxnrRLML2uSJWiUTp8lQ=; b=WnUHngym1FArx7TopCrj27cs2X94Ub7XH2HvNHytPYZjlLz/PdGw50uPMGGX7QQvGk iWPp+QaZTGjQGQmjSyhd/C4o9E92b0xm6MSBS9OvIiqZO4h5kxcn7qDIv26hEiRC3Uzr n9W3a71Cnb8unkum9oC2AF/rqzmPSW4M6GeAPyAscu44Z3ZRnlntdX+5t9w2NVXStpUs RE9jwbgruNq8ST8o+lwqBtLOe4pPb98FBKF8Vi6y0ZPpKVwqwNm/P0n0zTKyaep5l7a8 I+F4hRdwTpd7zCCJfBHMWgF7Y4IiZEA87OkzsvPQHcPciVoOw27VLCst1CWWBIRDWpJ+ ZIXg== X-Received: by 10.152.22.130 with SMTP id d2mr2852333laf.33.1370801476989; Sun, 09 Jun 2013 11:11:16 -0700 (PDT) Received: by 10.114.59.202 with HTTP; Sun, 9 Jun 2013 11:11:16 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Jun 9, 2013 at 1:06 PM, Ramkumar Ramachandra wrote: > Jeff King wrote: >> I already mentioned elsewhere that I think it would be fine to massage >> libgit.a in that direction. I even joined the conversation pointing out >> some cases where Felipe's ruby module would break. But I do not think >> that moving code in and out of libgit.a is an important first step at >> all. That is simply code that no library users would want to call, and >> is easy to deal with: move it out. The hard part is code that users >> _would_ want to call, and is totally broken. Patches dealing with that >> are the hard obstacle that people working in this direction would need >> to overcome. But I do not see any such patches under discussion. > > Forget the rest; this makes it clear. Thanks, and sorry for all the confusion. > > So, reorganization is not the first step. Can you please post an > example patch illustrating what needs to be done, so we can follow? If you have a code-base with 100 functions, 10 of which make sense in a public library, instead of going ahead to fix those 10 functions, it makes sense to *first* separate those 10 functions, and *then* clean them up for public usage. But let's assume that Jeff is right and this is not the first step. It doesn't matter; I already started that step and created builtin/lib.a. Are you going to throw away that because it's not "the first step"? -- Felipe Contreras