From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Git <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Dominik Salvet <dominik.salvet@gmail.com>
Subject: Re: [RFC/PATCH] Add fetch.updateHead option
Date: Fri, 20 Nov 2020 19:53:11 -0600 [thread overview]
Message-ID: <CAMP44s2yi2v8ghoQ7ZsuxnFU66Hps1DRn3a1ytqBOqS2+pzLsA@mail.gmail.com> (raw)
In-Reply-To: <xmqq3613tuwy.fsf@gitster.c.googlers.com>
On Fri, Nov 20, 2020 at 6:28 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Jeff King <peff@peff.net> writes:
>
> > Thanks for working on this. Regardless of whether we change the default
> > behavior, this seems like an obvious improvement (and I do think it
> > makes sense to eventually change the default; I'd even be OK switching
> > it to "missing" in the near term).
>
> I agree that "missing" would be an easy thing to take, and I do not
> mind seeing it made the default in the near term. It won't break
> existing expectations too much, and can even be seen as a bugfix for
> the current behaviour by making "init && fetch" a step closer to
> "clone". Beyond that to modify what the end user already has is a
> much harder sell. For some it may be an improvement, but for others
> it would be a breaking change.
Changing the default to "missing" breaks a lot of tests. I already
have the fixes for the tests, but this can be seen as an indication
that the expectations of users would change.
I never knew of this $remote/HEAD feature, and searching forums some
people seem perplexed by its existence and ask how to remove it.
So, if the "missing" behavior is the one we are targeting (which I
argue we should), we probably need a warning before doing the flip, so
that users become aware of the feature and are not surprised by a
sudden $remote/HEAD popping (or repopping) seemingly out of nowhere.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2020-11-21 1:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 9:12 [RFC/PATCH] Add fetch.updateHead option Felipe Contreras
2020-11-18 9:30 ` Ævar Arnfjörð Bjarmason
2020-11-18 9:43 ` Felipe Contreras
2020-11-18 15:53 ` Junio C Hamano
2020-11-18 19:04 ` Felipe Contreras
2020-11-20 23:52 ` Jeff King
2020-11-21 0:28 ` Junio C Hamano
2020-11-21 0:40 ` Jeff King
2020-11-21 1:18 ` Felipe Contreras
2020-11-24 6:58 ` Jeff King
2020-11-21 1:53 ` Felipe Contreras [this message]
2020-11-21 1:41 ` Felipe Contreras
2020-11-24 7:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2yi2v8ghoQ7ZsuxnFU66Hps1DRn3a1ytqBOqS2+pzLsA@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=dominik.salvet@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).