From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
SZEDER Gabor <szeder@ira.uka.de>,
Matthieu Moy <matthieu.moy@grenoble-inp.fr>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH v5 2/3] tests: use __gitcompadd to simplify completion tests
Date: Tue, 16 Oct 2012 02:24:54 +0200 [thread overview]
Message-ID: <CAMP44s2ej4oz4E4tYk7hNjBXe-pvK-v2kQDuz9pg42stBtL61w@mail.gmail.com> (raw)
In-Reply-To: <1350229971-9343-3-git-send-email-felipe.contreras@gmail.com>
On Sun, Oct 14, 2012 at 5:52 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> -print_comp ()
> +__gitcompadd ()
> {
> - local IFS=$'\n'
> - echo "${COMPREPLY[*]}" > out
> + compgen -P "${2-}" -S "${4- }" -W "$1" -- "${3-$cur}" > out
Rather:
compgen -W "$1" -P "$2" -S "$4" -- "$3" > out
--
Felipe Contreras
next prev parent reply other threads:[~2012-10-16 0:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 15:52 [PATCH v5 0/3] completion: refactor and zsh wrapper Felipe Contreras
2012-10-14 15:52 ` [PATCH v5 1/3] completion: add new __gitcompadd helper Felipe Contreras
2012-10-17 17:28 ` SZEDER Gábor
2012-10-22 0:41 ` Felipe Contreras
2012-10-30 23:18 ` SZEDER Gábor
2012-10-14 15:52 ` [PATCH v5 2/3] tests: use __gitcompadd to simplify completion tests Felipe Contreras
2012-10-16 0:24 ` Felipe Contreras [this message]
2012-10-17 17:50 ` SZEDER Gábor
2012-10-17 17:54 ` [PATCH] completion: clean up __gitcomp() tests SZEDER Gábor
2012-10-17 18:21 ` Felipe Contreras
2012-10-17 18:26 ` [PATCH v5 2/3] tests: use __gitcompadd to simplify completion tests Felipe Contreras
2012-10-14 15:52 ` [PATCH v5 3/3] completion: add new zsh completion Felipe Contreras
2012-10-15 6:38 ` Felipe Contreras
2012-10-15 16:45 ` [PATCH v5 0/3] completion: refactor and zsh wrapper Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2ej4oz4E4tYk7hNjBXe-pvK-v2kQDuz9pg42stBtL61w@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).