From: Felipe Contreras <felipe.contreras@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH] Add new git-remote-hd helper
Date: Wed, 17 Oct 2012 20:33:07 +0200 [thread overview]
Message-ID: <CAMP44s2-BCuA5v7jE8S3d-Gg+DxKf6Yte9MvTDBDr4jEkLKZ9g@mail.gmail.com> (raw)
In-Reply-To: <CAGdFq_i4c=ei4ni5bv9nNEbCfNG4sbRkqyip2voW17GhkRAKPQ@mail.gmail.com>
On Wed, Oct 17, 2012 at 8:18 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> On Wed, Oct 17, 2012 at 11:12 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> But fine, lets remove the tests out of the equation (150 lines), the
>> number of lines of code still exceeds 3000.
>
> I don't think it's fair to just look at LOC, git-remote-hg when it was
> just parsing was fairly simple. Most of the current code is our copy
> of the python fast-import library which is only used to support
> pushing to mercurial.
Well, as a rule of thumb more code means more places for bugs to hide.
It is also quite frankly rather difficult to navigate; very
spaghetti-like. I have the feeling I can implement the same
fast-import functionality in a much simpler way, but for now I want to
concentrate on fetching, and hopefully making it easy for people to
actually use it.
I would like to cooperate as much as possible, but as I said, I would
rewrite a lot of that code. And also, I'm not even sure which
repository contains the latest version of this code. I've seen a
couple of them that are quite different, and none which are based on a
recent version of git.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-10-17 18:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 12:58 [PATCH] Add new git-remote-hd helper Felipe Contreras
2012-10-17 16:03 ` Johannes Schindelin
2012-10-17 16:38 ` Felipe Contreras
2012-10-17 17:39 ` Johannes Schindelin
2012-10-17 18:12 ` Felipe Contreras
2012-10-17 18:18 ` Sverre Rabbelier
2012-10-17 18:33 ` Felipe Contreras [this message]
2012-10-18 8:47 ` Johannes Schindelin
2012-10-18 9:03 ` Felipe Contreras
2012-10-18 9:10 ` Johannes Schindelin
2012-10-18 9:26 ` Junio C Hamano
2012-10-18 9:38 ` Felipe Contreras
2012-10-18 9:42 ` Matthieu Moy
2012-10-21 18:03 ` Felipe Contreras
2012-10-21 20:03 ` Johannes Schindelin
2012-10-21 20:31 ` Felipe Contreras
2012-10-17 22:59 ` Jeff King
2012-10-18 3:44 ` Felipe Contreras
2012-10-18 5:18 ` Felipe Contreras
2012-10-18 6:12 ` Sverre Rabbelier
2012-10-18 9:10 ` Felipe Contreras
2012-10-18 9:13 ` Johannes Schindelin
2012-10-18 9:22 ` Felipe Contreras
2012-10-26 9:02 ` Felipe Contreras
2012-10-18 8:48 ` Felipe Contreras
2012-10-18 13:18 ` Michael J Gruber
2012-10-18 14:26 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2-BCuA5v7jE8S3d-Gg+DxKf6Yte9MvTDBDr4jEkLKZ9g@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).