From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Contreras Subject: Re: [PATCHv2 8/8] send-email: do not prompt for explicit repo ident Date: Fri, 16 Nov 2012 20:57:43 +0100 Message-ID: References: <20121115003029.GA17550@sigill.intra.peff.net> <20121115003640.GH17819@sigill.intra.peff.net> <20121115083315.GA23377@sigill.intra.peff.net> <20121115104345.GA32465@sigill.intra.peff.net> <20121115111334.GA1879@sigill.intra.peff.net> <7vvcd6954q.fsf@alter.siamese.dyndns.org> <20121115172845.GA20298@sigill.intra.peff.net> <7vzk2i6s9h.fsf@alter.siamese.dyndns.org> <20121116190811.GB2310@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Junio C Hamano , git@vger.kernel.org, Thomas Rast , Jonathan Nieder To: Jeff King X-From: git-owner@vger.kernel.org Fri Nov 16 20:58:00 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZS35-0000Rg-48 for gcvg-git-2@plane.gmane.org; Fri, 16 Nov 2012 20:57:59 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484Ab2KPT5p (ORCPT ); Fri, 16 Nov 2012 14:57:45 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:35643 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365Ab2KPT5o (ORCPT ); Fri, 16 Nov 2012 14:57:44 -0500 Received: by mail-oa0-f46.google.com with SMTP id h16so3158492oag.19 for ; Fri, 16 Nov 2012 11:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qpkJKKVRVBeCxbRtu+LNa09ebOX5174CbCn41lNFckk=; b=y3Z9a2QFk6V1L8tvZZTTyfauRw07HhXTxGOpIzmR2PJCEPglc0bAfwpCAXxU4lnbRC n11lI2+usywmJ+lWPpKmNQx+EHmQDpufxfBzW1WdJss/raX8KPXSoh5wl6FhBjKc6y+q GhS4CHk6wkuNXPbIREiIPLCaThjWSvn/lOF0HAxzM/GMsZUKgFX50sD+kTPPoVPHuj8G pvwFNFkw9E/ytHZm/AbpKd3BAPq/dKiSeuCvvfwGMJoVSI3eUYjyNZe+4df4MlHSlrET pE0/DJouBwyUtqcqCmnKS7CjyfjaFzP3aSCx2C3Vr0+8w+S497XlDL7pNq3OphLwEpAn IyOQ== Received: by 10.60.32.19 with SMTP id e19mr4972169oei.9.1353095864013; Fri, 16 Nov 2012 11:57:44 -0800 (PST) Received: by 10.60.4.74 with HTTP; Fri, 16 Nov 2012 11:57:43 -0800 (PST) In-Reply-To: <20121116190811.GB2310@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Nov 16, 2012 at 8:08 PM, Jeff King wrote: > On Thu, Nov 15, 2012 at 09:17:30PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > That is a good question. That confirmation step does come after they >> > have typed their cover letter. However, if they are using --compose, >> > they are dumped in their editor with something like: >> > >> > From Jeff King # This line is ignored. >> > GIT: Lines beginning in "GIT:" will be removed. >> > GIT: Consider including an overall diffstat or table of contents >> > GIT: for the patch you are writing. >> > GIT: >> > GIT: Clear the body content if you don't wish to send a summary. >> > From: Jeff King >> > Subject: >> > In-Reply-To: >> > >> > which I think would count as sufficient notice of the address being >> > used. >> >> OK. Tentatively I replaced your old series with these 8 patches >> including the last one, as I tend to agree with the value the >> earlier clean-up in the series gives us in the longer term. As you >> and Felipe discussed, we may want to replace the last one with a >> simpler "don't bother asking" patch, but I think that is more or >> less an orthogonal issue. > > I'm not sure how orthogonal it is. The latter half of my series is about > exposing the user_ident_sufficiently_given() flag. If we go with > Felipe's patch, then that exposed information has no users, and it may > not be worth it (OTOH, it's possible that some third-party script may > want it). Well, who is using user_ident_sufficiently_given() in the first place? I think 'git commit' might be suffering from the same problem that prompted you to split it. Cheers. -- Felipe Contreras