From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
Dominik Salvet <dominik.salvet@gmail.com>
Subject: Re: [RFC/PATCH] Add fetch.updateHead option
Date: Wed, 18 Nov 2020 03:43:19 -0600 [thread overview]
Message-ID: <CAMP44s1i+defrfkCprTAOqyJSCAUMsqWe3Fyv+Y2TeAyiAdg8g@mail.gmail.com> (raw)
In-Reply-To: <87wnyjdnb3.fsf@evledraar.gmail.com>
On Wed, Nov 18, 2020 at 3:30 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> I haven't taken much time to re-think through the patch/implications of
> this, but I remember running into this and going through some pre-patch
> investigation at some point.
>
> It's really annoying in some cases that "clone" isn't creating the same
> state as "remote". IIRC I was doing some heuristics to figure out the
> remote branch name etc.
>
> Isn't this something we can just change without an option? There were a
> bunch of cases in clone/fetch that were different for no different
> reasons, IIRC I patched one or two of those in the past. But I haven't
> gone through the history of the feature and checked if it was
> intentional.
Apparently remote/HEAD is supposed to be set manually, which is why
there is "git remote add -m master", and "git remote set-head origin
master".
Personally I don't see any point in that.
I think if no remote/HEAD is set (manually), it should be set
automatically on the first "git fetch", and that should mirror the
behavior of "git clone". This would be the equivalent of
"fetch.updatehead = missing", which in my opinion should be the
default.
This configuration was suggested by Jeff King, see:
https://lore.kernel.org/git/20201118020618.GE650959@coredump.intra.peff.net/
Personally I don't need a configuration, I would be happy if
"fetch.updatehead = missing" was the default.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2020-11-18 9:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 9:12 [RFC/PATCH] Add fetch.updateHead option Felipe Contreras
2020-11-18 9:30 ` Ævar Arnfjörð Bjarmason
2020-11-18 9:43 ` Felipe Contreras [this message]
2020-11-18 15:53 ` Junio C Hamano
2020-11-18 19:04 ` Felipe Contreras
2020-11-20 23:52 ` Jeff King
2020-11-21 0:28 ` Junio C Hamano
2020-11-21 0:40 ` Jeff King
2020-11-21 1:18 ` Felipe Contreras
2020-11-24 6:58 ` Jeff King
2020-11-21 1:53 ` Felipe Contreras
2020-11-21 1:41 ` Felipe Contreras
2020-11-24 7:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1i+defrfkCprTAOqyJSCAUMsqWe3Fyv+Y2TeAyiAdg8g@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=dominik.salvet@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).