From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH 0/6] test: make the test suite work with zsh
Date: Thu, 30 Mar 2023 01:47:09 -0600 [thread overview]
Message-ID: <CAMP44s1Amx4raO2rzTHxCgfEXywZwPCJwJ8edzJO_+_pY8PAkg@mail.gmail.com> (raw)
In-Reply-To: <xmqqjzyz3p5n.fsf@gitster.g>
On Wed, Mar 29, 2023 at 9:15 PM Junio C Hamano <gitster@pobox.com> wrote:
> If the native mode didn't impose too much burden on our developers'
> to maintain, it would have been nicer, but judging from the contents
> of these patches, I am afraid that it falls on the other side of the
> line.
There is zero burden to maintain.
What burden did this fix specific for ksh93 cause to "our developers"
0e418e568f (t0005: work around strange $? in ksh when program
terminated by a signal, 2010-07-09)?
--- a/t/t0005-signals.sh
+++ b/t/t0005-signals.sh
@@ -13,6 +13,7 @@ test_expect_success 'sigchain works' '
test-sigchain >actual
case "$?" in
143) true ;; # POSIX w/ SIGTERM=15
+ 271) true ;; # ksh w/ SIGTERM=15
3) true ;; # Windows
*) false ;;
esac &&
This patch was applied once and forgotten about for 6 six years until
one developer refactored the code in 9b67c9942e (tests: factor
portable signal check out of t0005, 2016-06-30).
"Our developers" did not have to care about code that affected only
one shell. Not since 2010, not since 2016, not even today.
Even the original author admitted he didn't understand how this code
truly interacted in other situations [1]:
> Frankly, I don't know how bash's 'kill -TERM' and a Windows program
> interact. I've avoided this topic like the plague so far.
It's not true that applying patches to fix a situation for a specific
shell causes a hypothetical burden to our developers to magically
appear.
In reality the patch is applied once and forgotten about it until a)
another developer stumbles upon a similar problem, or b) another
developer stumbles upon that specific code.
No developer cared about 0e418e568f being applied. It fixed the
situation for one shell, it didn't affect other shells negatively, and
that's all anyone needed to know.
[1] https://lore.kernel.org/git/576DA6FB.1050108@kdbg.org
--
Felipe Contreras
prev parent reply other threads:[~2023-03-30 7:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 17:39 [PATCH 0/6] test: make the test suite work with zsh Felipe Contreras
2023-03-28 17:39 ` [PATCH 1/6] test: fix build for zsh Felipe Contreras
2023-03-28 17:39 ` [PATCH 2/6] test: avoid `stat` variable Felipe Contreras
2023-03-29 9:48 ` Ævar Arnfjörð Bjarmason
2023-04-01 0:05 ` Taylor Blau
2023-04-01 0:25 ` Felipe Contreras
2023-03-28 17:39 ` [PATCH 3/6] test: avoid `options` variable Felipe Contreras
2023-03-28 17:39 ` [PATCH 4/6] test: avoid `path` variable Felipe Contreras
2023-03-28 17:39 ` [PATCH 5/6] test: hack for zsh Felipe Contreras
2023-03-30 8:15 ` Felipe Contreras
2023-03-28 17:39 ` [PATCH 6/6] mergetools: vimdiff: check for empty fields Felipe Contreras
2023-03-29 0:57 ` [PATCH 0/6] test: make the test suite work with zsh brian m. carlson
2023-03-29 1:57 ` Felipe Contreras
2023-03-29 9:51 ` Ævar Arnfjörð Bjarmason
2023-03-29 11:19 ` Felipe Contreras
2023-03-30 13:00 ` Felipe Contreras
2023-03-29 15:34 ` Junio C Hamano
2023-03-29 21:54 ` Felipe Contreras
2023-03-30 10:15 ` Junio C Hamano
2023-03-30 14:19 ` Felipe Contreras
2023-04-01 0:04 ` Taylor Blau
2023-04-01 0:59 ` Felipe Contreras
2023-04-01 1:30 ` Junio C Hamano
2023-04-01 2:39 ` Felipe Contreras
2023-04-01 0:00 ` Taylor Blau
2023-04-01 0:50 ` Felipe Contreras
2023-03-29 22:14 ` brian m. carlson
2023-03-30 3:15 ` Junio C Hamano
2023-03-30 7:47 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1Amx4raO2rzTHxCgfEXywZwPCJwJ8edzJO_+_pY8PAkg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).