From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 1/3] fetch: add --allow-local option
Date: Thu, 16 May 2013 11:26:19 -0500 [thread overview]
Message-ID: <CAMP44s14TSGtQ7kvWUgrOQvT1uKciSV5fd5pQvy1ven8Z=qVcg@mail.gmail.com> (raw)
In-Reply-To: <7v61yi9arl.fsf@alter.siamese.dyndns.org>
On Thu, May 16, 2013 at 10:58 AM, Junio C Hamano <gitster@pobox.com> wrote:
> I _think_ the real reason you want a "git fetch" while on "mywork"
> to go to 'origin' is because you are building your "master" off of
> somebody else's work that comes from 'origin', and you want to check
> what has changed to see what you need to rebuild both your "master"
> and "mywork" branches on top of. If 'master' were forked from a
> remote that is not 'origin', then making "git fetch" ignore '.' and
> instead go to 'origin' would not solve anything. For an updated
> behaviour to be useful in that workflow, it needs to follow the
> inter-branch relationship ("mywork is a fork of master which is a
> fork of frotz branch from a remote xyzzy") to see the first remote
> repository and fetch from there, instead of blindly fetching from
> the 'origin'.
No, the reason I want 'git fetch' to fetch 'origin' is because it has
always done so. It only stopped doing so when I configured 'upstream'
branches. I'm not even sure I want 'git fetch' to fetch from the
remote of my current branch if it has an upstream branch.
> Having said all that, I am not all that sure that it is a good idea
> to introduce such an exception for "git fetch" to ignore '.',
> regardless of where it goes instead, either the 'origin' or the
> first remote repository it finds by recursively finding its
> upstreams, to break the consistency at the UI level. It is dubious
> if the benefit of convenience to fetch from remote 'xyzzy' that is
> an eventual remote of 'mywork' without having to say so outweighs
> the cost of additional UI inconsistency, making things harder to
> explain to both new and old people.
That doesn't change the fact that 'git fetch .' does not make any
sense whatsoever. The user *will* get confused when (s)he does 'git
fetch' and nothing happens. The problem is not solved.
% git checkout -b fixes master
% git fetch
% git branch -u master
% git fetch
# scratch head
--
Felipe Contreras
next prev parent reply other threads:[~2013-05-16 16:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 7:31 [PATCH 0/3] fetch: fix '.' fetching Felipe Contreras
2013-05-16 7:31 ` [PATCH 1/3] fetch: add --allow-local option Felipe Contreras
2013-05-16 8:25 ` Ramkumar Ramachandra
2013-05-16 8:53 ` Felipe Contreras
2013-05-16 9:27 ` Ramkumar Ramachandra
2013-05-16 9:34 ` Felipe Contreras
2013-05-16 9:58 ` Ramkumar Ramachandra
2013-05-16 10:27 ` Felipe Contreras
2013-05-16 10:32 ` Ramkumar Ramachandra
2013-05-16 12:54 ` Felipe Contreras
2013-05-16 15:58 ` Junio C Hamano
2013-05-16 16:26 ` Felipe Contreras [this message]
2013-05-16 16:38 ` Junio C Hamano
2013-05-16 16:52 ` Felipe Contreras
2013-05-16 18:04 ` Junio C Hamano
2013-05-16 23:07 ` Felipe Contreras
2013-05-16 23:24 ` Junio C Hamano
2013-05-17 0:04 ` Felipe Contreras
2013-05-17 18:30 ` Junio C Hamano
2013-05-18 12:25 ` Felipe Contreras
2013-05-19 5:51 ` Junio C Hamano
2013-05-19 6:10 ` Felipe Contreras
2013-05-19 7:56 ` About overzealous compatibility Felipe Contreras
2013-05-19 14:27 ` Felipe Contreras
2013-05-18 13:12 ` [PATCH 1/3] fetch: add --allow-local option Philip Oakley
2013-05-18 14:23 ` Felipe Contreras
2013-05-18 20:53 ` Philip Oakley
2013-05-18 22:26 ` Felipe Contreras
2013-05-19 6:10 ` Junio C Hamano
2013-05-16 7:31 ` [PATCH 2/3] fetch: switch allow-local off by default Felipe Contreras
2013-05-16 7:31 ` [PATCH 3/3] remote: disable allow-local for pushes Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s14TSGtQ7kvWUgrOQvT1uKciSV5fd5pQvy1ven8Z=qVcg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).