From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Contreras Subject: Re: [PATCH 1/3] t9350: point out that refs are not updated correctly Date: Thu, 25 Oct 2012 15:33:03 +0200 Message-ID: References: <20121025042731.GA11243@elie.Belkin> <20121025052823.GB11243@elie.Belkin> <20121025073454.GB15790@elie.Belkin> <20121025074829.GD15790@elie.Belkin> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Jonathan Nieder , Johannes Schindelin , Junio C Hamano , Jeff King , Git List , Daniel Barkalow , Ramkumar Ramachandra , Dmitry Ivankov , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= , Eric Herman , Fernando Vezzosi To: Sverre Rabbelier X-From: git-owner@vger.kernel.org Thu Oct 25 15:33:20 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TRNYk-0004iN-NP for gcvg-git-2@plane.gmane.org; Thu, 25 Oct 2012 15:33:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759493Ab2JYNdG (ORCPT ); Thu, 25 Oct 2012 09:33:06 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:54336 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759057Ab2JYNdE (ORCPT ); Thu, 25 Oct 2012 09:33:04 -0400 Received: by mail-ob0-f174.google.com with SMTP id uo13so1545604obb.19 for ; Thu, 25 Oct 2012 06:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zLuB1kcxiXuYs5Yr7/MHiujjAunglF0EYRkIk2K4/64=; b=mdQpJnieKi1hVERhwhm1f5SifkyPTjvRbWT40XLW3qo0sanIkcOGFyswIhBam89jgw bwwoJbg0ta1DPTBlVpQ/omysYUOTszc/YJBiIloa3UWKFims6gnlUnV3Ugv7tkwfC4z8 pU9KgYuY8oC6Oz29OYD0/9jpe3K6zNuBIs6I0WtJsbimcXvhiJQA9wAv7K8OlfRPbWnG wy/7cl5VKiZVqyxX5cMyg1AMQTNGn3/5k3C9hsZ7FxGpvnedU/57FA/pWVh/ioLJ0qkE z1C6BxarOWEhjkxpoYJwE5nbwgwMY2VD8OLKMt0KcSRJD4XdfBprI8RnOdtndeSbUcYh Cwug== Received: by 10.60.27.201 with SMTP id v9mr7768766oeg.85.1351171983907; Thu, 25 Oct 2012 06:33:03 -0700 (PDT) Received: by 10.60.4.74 with HTTP; Thu, 25 Oct 2012 06:33:03 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Oct 25, 2012 at 9:50 AM, Sverre Rabbelier wrote: > On Thu, Oct 25, 2012 at 12:48 AM, Jonathan Nieder wrote: >> Sverre Rabbelier wrote: >> >>> I know there was a reason why using UNINTERESTING didn't work >>> (otherwise we could've used that to start with, instead of needing >>> Junio's whence solution). I think all refs ended up being marked as >>> UNINTERESTING or somesuch. >> >> True. Is it be possible to check UNINTERESTING in revs->cmdline >> before the walk? It is possible to check in revs->pending, but '^foo master' will mark them both as UNINTERESTING, and 'master..master' as well, which again, is what we actually want, because that's how it works in the rest of git. > That might work, maybe Dscho remembers why we did not go with that approach. Because you want 'master..master' to output something, but that's wrong; it's changing the semantics of commitishes, and you don't need that to solve this problem. -- Felipe Contreras