From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
Sverre Rabbelier <srabbelier@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Elijah Newren <newren@gmail.com>,
Thiago Farina <tfransosi@gmail.com>
Subject: Re: [PATCH v6 p2 1/9] transport-helper: update remote helper namespace
Date: Sat, 24 Nov 2012 04:28:39 +0100 [thread overview]
Message-ID: <CAMP44s070w14K5ODv=5s2f0agV1aVn3FSBmXMmM6M2UqPd7Sdw@mail.gmail.com> (raw)
In-Reply-To: <1353727520-26039-2-git-send-email-felipe.contreras@gmail.com>
On Sat, Nov 24, 2012 at 4:25 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> @@ -673,11 +675,23 @@ static void push_update_refs_status(struct helper_data *data,
> struct strbuf buf = STRBUF_INIT;
> struct ref *ref = remote_refs;
> for (;;) {
> + char *private;
> +
> recvline(data, &buf);
> if (!buf.len)
> break;
>
> - push_update_ref_status(&buf, &ref, remote_refs);
> + if (push_update_ref_status(&buf, &ref, remote_refs))
> + continue;
> +
> + if (!data->refspecs)
> + continue;
> +
> + /* propagate back the update to the remote namespace */
> + private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name);
> + if (!private)
> + continue;
> + update_ref("update by helper", private, ref->new_sha1, NULL, 0, 0);
free(private); I guess
--
Felipe Contreras
next prev parent reply other threads:[~2012-11-24 3:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-24 3:25 [PATCH v6 p2 0/9] transport-helper and fast-export fixes Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 1/9] transport-helper: update remote helper namespace Felipe Contreras
2012-11-24 3:28 ` Felipe Contreras [this message]
2012-11-24 3:25 ` [PATCH v6 p2 2/9] fast-export: don't handle uninteresting refs Felipe Contreras
2012-11-24 3:27 ` Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 3/9] transport-helper: trivial code shuffle Felipe Contreras
2012-11-27 17:00 ` Junio C Hamano
2012-11-28 0:05 ` Felipe Contreras
2012-11-28 1:54 ` Junio C Hamano
2012-11-28 2:15 ` Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 4/9] transport-helper: fix push without refspec Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 5/9] transport-helper: fix pushing with straight refspec Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 6/9] transport-helper: fix push without marks Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 7/9] fast-export: make extra_refs global Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 8/9] fast-export: refactor get_tags_and_duplicates() Felipe Contreras
2012-11-24 3:25 ` [PATCH v6 p2 9/9] fast-export: trivial cleanups Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s070w14K5ODv=5s2f0agV1aVn3FSBmXMmM6M2UqPd7Sdw@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).