From: Prathamesh Chavan <pc44800@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] t2027: avoid using pipes
Date: Thu, 9 Mar 2017 14:26:09 +0530 [thread overview]
Message-ID: <CAME+mvUDsBec0L9o_wpAMin-rbn-SqS1OZcuyfRw+U7b-EOXeQ@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD0GtRdjCMcbhjgA0rVaAMFtyto8JxfqbivODarBB0eK8w@mail.gmail.com>
On Thu, Mar 9, 2017 at 1:38 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> On Wed, Mar 8, 2017 at 4:13 PM, Prathamesh Chavan <pc44800@gmail.com> wrote:
>> The exit code of the upstream of a pipe is ignored thus we should avoid
>> using it.
>
> You might want to say more specifically that we should avoid piping a
> git command into another one as this could mask a failure of the git
> command.
Yes. I will add be specific, and update my patch.
>
>> By writing out the output of the git command to a file, we
>> can test the exit codes of both the commands.
>>
>> Signed-off-by: Prathamesh <pc44800@gmail.com>
>> ---
>> t/t2027-worktree-list.sh | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/t/t2027-worktree-list.sh b/t/t2027-worktree-list.sh
>> index 848da5f..daa7a04 100755
>> --- a/t/t2027-worktree-list.sh
>> +++ b/t/t2027-worktree-list.sh
>> @@ -31,7 +31,7 @@ test_expect_success '"list" all worktrees from main' '
>> test_when_finished "rm -rf here && git worktree prune" &&
>> git worktree add --detach here master &&
>> echo "$(git -C here rev-parse --show-toplevel) $(git rev-parse --short HEAD) (detached HEAD)" >>expect &&
>> - git worktree list | sed "s/ */ /g" >actual &&
>> + git worktree list >out && sed "s/ */ /g" <out >actual &&
>
> I think it's better if the 'sed' command is on a separate line.
>
> Also you may have used just "out" instead of "<out" in the 'sed' command...
>
Actually I noticed that:
$ git grep sed |grep "<" |wc -l
307
As at most places, wherever pipes aren't being used, the input to sed command is
passed using "<". Hence I chose to use "<" at places specifically at
places where sed
was used, even after knowing that just "out" will work.
>> test_cmp expect actual
>> '
>>
>> @@ -118,9 +118,9 @@ test_expect_success 'broken main worktree still at the top' '
>> cd linked &&
>> echo "worktree $(pwd)" >expected &&
>> echo "ref: .broken" >../.git/HEAD &&
>> - git worktree list --porcelain | head -n 3 >actual &&
>> + git worktree list --porcelain >out && head -n 3 out >actual &&
>
> ... as above you use "out" not "<out" in the 'head' command.
>
>> test_cmp ../expected actual &&
>> - git worktree list | head -n 1 >actual.2 &&
>> + git worktree list >out && head -n 1 out >actual.2 &&
>> grep -F "(error)" actual.2
>> )
>> '
next prev parent reply other threads:[~2017-03-09 9:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 15:13 [PATCH] t2027: avoid using pipes Prathamesh Chavan
2017-03-08 15:44 ` Jon Loeliger
2017-03-08 21:38 ` Prathamesh Chavan
2017-03-08 22:13 ` Prathamesh Chavan
2017-03-09 8:08 ` Christian Couder
2017-03-09 8:56 ` Prathamesh Chavan [this message]
2017-03-09 9:39 ` [PATCH v2] " Prathamesh Chavan
2017-03-09 9:53 ` Prathamesh Chavan
2017-03-09 12:30 ` Christian Couder
2017-03-09 19:18 ` [PATCH] " Prathamesh Chavan
2017-03-10 13:34 ` [PATCH v2] " Prathamesh Chavan
-- strict thread matches above, loose matches on Subject: below --
2017-03-09 19:03 [PATCH] " Prathamesh Chavan
2017-03-09 20:15 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAME+mvUDsBec0L9o_wpAMin-rbn-SqS1OZcuyfRw+U7b-EOXeQ@mail.gmail.com \
--to=pc44800@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).