Re: git 2.16, Jenkins git client plugin, and ""

[Mark Waite <mwaite@cloudbees.com>]

On Wed, Jan 24, 2018 at 5:31 PM, Bryan Turner <bturner@atlassian.com> wrote:
> On Wed, Jan 24, 2018 at 3:55 PM, Mark Waite <mwaite@cloudbees.com> wrote:
>> It appears that git 2.16.0 and 2.16.1 have introduced a change which
>> surprises the Jenkins git client plugin.
>>
>> Git 2.16.0 and 2.16.1 on Linux both report "fatal: ssh variant
>> 'simple' does not support setting port" when used in the context of
>> the Jenkins git client plugin.
>
> We noticed a similar issue in Bitbucket Server's tests, related to us
> using a wrapper script with the GIT_SSH variable. Some further
> discussion is available in [1].

Thanks for the confirmation!

>> Is the GIT_SSH_VARIANT solution expected to be used by git consumers
>> like the Jenkins git client plugin when passing credential information
>> through environment variables like SSH_ASKPASS?
>
> The expectation seems to be that if you use GIT_SSH or
> GIT_SSH_COMMAND, you'll also use GIT_SSH_VARIANT to tell Git what to
> expect, because it doesn't (shouldn't?) make assumptions, starting in
> 2.16, that your custom SSH uses OpenSSH syntax.

That seems sensible.  There are other areas in the plugin which assume
OpenSSH syntax, so it is fair to make it explicit in the plugin.

We'll proceed with GIT_SSH_VARIANT=ssh.

>> Is this a bug, or is this the new, intentional behavior of git?
>
> It's intentional. There was some discussion (again, see [1]) about
> whether the change needed further changes, but it doesn't appear any
> further changes were made.

Thanks very much!

>>
>> Thanks,
>> Mark Waite
>
> [1]: https://public-inbox.org/git/CAGyf7-FQp4q2vvH1ponQvmVDTu0hiMSK1JKytQZ4O1i0MCnz7g@mail.gmail.com/
>
> Hope this helps!
> Bryan

-- 
Mark Waite