git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Mark Waite <mwaite@cloudbees.com>
To: Bryan Turner <bturner@atlassian.com>
Cc: Git Users <git@vger.kernel.org>
Subject: Re: git 2.16, Jenkins git client plugin, and ""
Date: Wed, 24 Jan 2018 17:36:37 -0700
Message-ID: <CAM2y_jUOOJhf6Cy3e5GosB7ZJXRh1b8XBH8H5xCw-d7uXd=9-w@mail.gmail.com> (raw)
In-Reply-To: <CAGyf7-Hb+w23sbW8rZxmLXBDO-+kBDFwirN3siSNwveYdX4qPg@mail.gmail.com>

On Wed, Jan 24, 2018 at 5:31 PM, Bryan Turner <bturner@atlassian.com> wrote:
> On Wed, Jan 24, 2018 at 3:55 PM, Mark Waite <mwaite@cloudbees.com> wrote:
>> It appears that git 2.16.0 and 2.16.1 have introduced a change which
>> surprises the Jenkins git client plugin.
>>
>> Git 2.16.0 and 2.16.1 on Linux both report "fatal: ssh variant
>> 'simple' does not support setting port" when used in the context of
>> the Jenkins git client plugin.
>
> We noticed a similar issue in Bitbucket Server's tests, related to us
> using a wrapper script with the GIT_SSH variable. Some further
> discussion is available in [1].

Thanks for the confirmation!

>> Is the GIT_SSH_VARIANT solution expected to be used by git consumers
>> like the Jenkins git client plugin when passing credential information
>> through environment variables like SSH_ASKPASS?
>
> The expectation seems to be that if you use GIT_SSH or
> GIT_SSH_COMMAND, you'll also use GIT_SSH_VARIANT to tell Git what to
> expect, because it doesn't (shouldn't?) make assumptions, starting in
> 2.16, that your custom SSH uses OpenSSH syntax.

That seems sensible.  There are other areas in the plugin which assume
OpenSSH syntax, so it is fair to make it explicit in the plugin.

We'll proceed with GIT_SSH_VARIANT=ssh.

>> Is this a bug, or is this the new, intentional behavior of git?
>
> It's intentional. There was some discussion (again, see [1]) about
> whether the change needed further changes, but it doesn't appear any
> further changes were made.

Thanks very much!

>>
>> Thanks,
>> Mark Waite
>
> [1]: https://public-inbox.org/git/CAGyf7-FQp4q2vvH1ponQvmVDTu0hiMSK1JKytQZ4O1i0MCnz7g@mail.gmail.com/
>
> Hope this helps!
> Bryan

-- 
Mark Waite

      reply	other threads:[~2018-01-25  0:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 23:55 Mark Waite
2018-01-25  0:31 ` Bryan Turner
2018-01-25  0:36   ` Mark Waite [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM2y_jUOOJhf6Cy3e5GosB7ZJXRh1b8XBH8H5xCw-d7uXd=9-w@mail.gmail.com' \
    --to=mwaite@cloudbees.com \
    --cc=bturner@atlassian.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git