mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <>
To: Junio C Hamano <>
Cc: "Nguyễn Thái Ngọc Duy" <>,
	"Git mailing list" <>
Subject: Re: [PATCH] completion: clear cached --options when sourcing the completion script
Date: Mon, 26 Mar 2018 13:55:20 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Mar 23, 2018 at 6:35 PM, Junio C Hamano <> wrote:
> Junio C Hamano <> writes:

>> I'd say we should just add !GETTEXT_POISON prereq to the problematic
>> tests.

> IOW, this is the minumum required.

Thanks for already committing the fix, I couldn't get around to it.

> By the way, shouldn't we be running the body of these new tests
> inside a subshell?  Otherwise a dot-sourcing by an earlier test of
> these new ones _will_ affect all the subsequent tests.

I don't think it matters.  All new tests first initialize the variable
they are interested in before sourcing the completion script, to avoid
false successes caused by the variable being empty to begin with.

And it shouldn't matter, either, because in the end the users will
source the completion script into their main shell process, and it
should just work no matter how many times it gets sourced.

>  t/ | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/t/ b/t/
> index 4c86adadf2..b7f5b1e632 100755
> --- a/t/
> +++ b/t/
> @@ -1511,7 +1511,7 @@ test_expect_success 'sourcing the completion script clears cached porcelain comm
>         verbose test -z "$__git_porcelain_commands"
>  '
> -test_expect_success 'sourcing the completion script clears cached merge strategies' '
> +test_expect_success !GETTEXT_POISON 'sourcing the completion script clears cached merge strategies' '
>         __git_compute_merge_strategies &&
>         verbose test -n "$__git_merge_strategies" &&
>         . "$GIT_BUILD_DIR/contrib/completion/git-completion.bash" &&

      reply	other threads:[~2018-03-26 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 14:16 [PATCH] completion: clear cached --options when sourcing the completion script SZEDER Gábor
2018-03-22 17:06 ` Duy Nguyen
2018-03-23 15:14 ` SZEDER Gábor
2018-03-23 17:24   ` Junio C Hamano
2018-03-23 17:35     ` Junio C Hamano
2018-03-26 11:55       ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).