git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [RFC/PATCH] parse-options: introduce parse_subcommands
Date: Wed, 6 Jun 2012 19:40:39 +0530	[thread overview]
Message-ID: <CALkWK0nuJ2VrAUD5PsfnZzO5yDgB+h4xn8g=CTqmUvJ8DOdPNQ@mail.gmail.com> (raw)
In-Reply-To: <7vlik3t3j2.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano wrote:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>>  I found this patch in one of my branches from a long time ago.  I
>>  haven't written documentation and tests yet because I'm not fully
>>  convinced that I like this.
>>
>>  Thoughts?
>
> It looks like a static version of string_list_lookup() and does not
> have much reason to tie it to "subcommand".

How so?  I can use a string_list to keep subcommand->name and stuff
the callback into util.  Where do I put subcommand->help then?
I agree that there's no reason to tie it to subcommand though.

Ram

  reply	other threads:[~2012-06-06 14:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04  9:35 [RFC/PATCH] parse-options: introduce parse_subcommands Ramkumar Ramachandra
2012-06-04 17:01 ` Junio C Hamano
2012-06-06 14:10   ` Ramkumar Ramachandra [this message]
2012-06-06 17:26     ` Junio C Hamano
2012-06-08  8:56       ` [RFC] notes: attach help text to subcommands Ramkumar Ramachandra
2012-06-08 14:49         ` Junio C Hamano
2012-06-08 15:28           ` [PATCH] " Ramkumar Ramachandra
2012-06-08 15:36             ` Jonathan Nieder
2012-06-08 15:54               ` Felipe Contreras
2012-06-08 16:34                 ` Ramkumar Ramachandra
2012-06-13 15:04                   ` Felipe Contreras
2012-06-08 17:03             ` Junio C Hamano
2012-06-05 23:32 ` [RFC/PATCH] parse-options: introduce parse_subcommands Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALkWK0nuJ2VrAUD5PsfnZzO5yDgB+h4xn8g=CTqmUvJ8DOdPNQ@mail.gmail.com' \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).