From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Minchan Kim <minchan@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH] send-email: Fix documentation of --signed-off-by-cc option
Date: Thu, 20 Jun 2013 22:15:53 +0530 [thread overview]
Message-ID: <CALkWK0n+CMV64VxLMV6AqVxwpC2nyk=vh=0F+ESvKG2Mn9G7oA@mail.gmail.com> (raw)
In-Reply-To: <1371716811-12043-1-git-send-email-namhyung@gmail.com>
Namhyung Kim wrote:
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 40a9a9a..5694d98 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -238,7 +238,7 @@ Automating
> the value of 'sendemail.identity'.
>
> --[no-]signed-off-by-cc::
> - If this is set, add emails found in Signed-off-by: or Cc: lines to the
> + If this is set, add emails found in Signed-off-by: lines to the
> cc list. Default is the value of 'sendemail.signedoffbycc' configuration
> value; if that is unspecified, default to --signed-off-by-cc.
Correct, but I'd urge you to step back and look at all the options.
Cc lines in the body (called bodycc) are parsed: see
git-send-email.perl:1361. By default, everyone (cc, author, self,
sob, bodycc) is cc'ed by default. You can turn off each of these
individually using --supress-cc which can take values
(all|cccmd|cc|author|self|sob|body|bodycc). As you can see from
git-send-email.perl:400, the real purpose of --signed-off-by-cc is to
override a sendemail.suppresscc=sob; however, it can't override any
stronger values of suppresscc (body, all). So, it's mostly a
no-option, and there is no corresponding --[no-]bodycc-cc. Overall,
the way out of this horrible mess of options is to deprecate
--[no-]signed-off-by-cc, and modify --supress-cc to have a
--no-suppress-cc counterpart, just like --[no-]suppress-from.
Thanks.
prev parent reply other threads:[~2013-06-20 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 8:26 [PATCH] send-email: Fix documentation of --signed-off-by-cc option Namhyung Kim
2013-06-20 16:45 ` Ramkumar Ramachandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0n+CMV64VxLMV6AqVxwpC2nyk=vh=0F+ESvKG2Mn9G7oA@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=minchan@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).