From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Dmitry Ivankov <divanorama@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Johan Herland <johan@herland.net>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 2/3] doc/fast-import: document feature import-marks-if-exists
Date: Wed, 13 Jul 2011 15:57:56 +0530 [thread overview]
Message-ID: <CALkWK0mkiVVAWpq2WMFZuSks4rJhrYA07Z0XyTFZUzxxmnUa-w@mail.gmail.com> (raw)
In-Reply-To: <1310483428-29833-3-git-send-email-divanorama@gmail.com>
Hi Dmitry,
In addition to Junio's comments, I have a few things to add:
Dmitry Ivankov writes:
> fast-import parameter --import-marks-if-exists was introduced in
It's a command-line option, not a parameter.
> commit dded4.. --import-marks can be set via a "feature" command in
Please more SHA-1 hex characters while abbreviating, and write a
little more information about the commit:
dded4f1 (fast-import: Introduce --import-marks-if-exists, 2011-01-15)
> a fast-import stream and --import-marks-if-exists has support for
> such specification too, for free.
>
> Document "feature import-marks-if-exists=<file>" command and add a
> minimalistic test for it.
Perhaps you can make it clearer that this feature was available back
in dded4f1, and was supposed to have been documented then?
Thanks for working on this. I'm to blame for not documenting/ testing
the feature in the original patch.
-- Ram
next prev parent reply other threads:[~2011-07-13 10:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 15:10 [PATCH 0/3] doc/{fast-import,remote-helpers}: few clarifications Dmitry Ivankov
2011-07-12 15:10 ` [PATCH 1/3] doc/fast-import: clarify notemodify command Dmitry Ivankov
2011-07-12 15:10 ` [PATCH 2/3] doc/fast-import: document feature import-marks-if-exists Dmitry Ivankov
2011-07-12 17:00 ` Junio C Hamano
2011-07-13 10:27 ` Ramkumar Ramachandra [this message]
2011-07-12 15:10 ` [PATCH 3/3] doc/remote-helpers: document the gitdir feature Dmitry Ivankov
2011-07-13 12:04 ` Sverre Rabbelier
2011-07-13 17:10 ` [PATCH v2 1/3] doc/fast-import: clarify notemodify command Dmitry Ivankov
2011-07-22 19:32 ` Johan Herland
2011-07-13 17:10 ` [PATCH v2 2/3] doc/fast-import: document feature import-marks-if-exists Dmitry Ivankov
2011-07-13 17:10 ` [PATCH v2 3/3] remote-helpers: export GIT_DIR variable to helpers Dmitry Ivankov
2011-07-13 17:14 ` Dmitry Ivankov
2011-07-13 17:36 ` Sverre Rabbelier
2011-07-13 18:10 ` Dmitry Ivankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkWK0mkiVVAWpq2WMFZuSks4rJhrYA07Z0XyTFZUzxxmnUa-w@mail.gmail.com \
--to=artagnon@gmail.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=jrnieder@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).