git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] submodule: make 'show' an alias for 'summary'
Date: Mon, 1 Oct 2012 23:03:49 +0530	[thread overview]
Message-ID: <CALkWK0mQMe1zfbPNf5prjgTwFtPKJuK=uwxqAqN_Q2=76e-=mA@mail.gmail.com> (raw)
In-Reply-To: <5069D24A.6060101@web.de>

Hi Jens,

Jens Lehmann wrote:
> Am 01.10.2012 08:45, schrieb Ramkumar Ramachandra:
>> Jens Lehmann wrote:
>>> I'm very interested in your feedback as a first time submodule user,
>>> what you wrote above makes sense and explains why you did that patch
>>> (and it would have been nice to read some of it in the commit message
>>> ;-). What information did you expect to get from a "git submodule
>>> show" which isn't already provided by "git status" and "git diff"
>>> (especially as they give you some information the "git submodule"
>>> commands don't)?
>>
>> I expected 'git submodule show' to list all the submodules, and show
>> changes to specific submodules like the 'git submodule summary'
>> output.
>
> Ok, but "git submodule summary" doesn't list all the submodules,
> only those with changes. Maybe "git submodule status" is closer
> to what you expect (except for the missing changes)?

Yes, "git submodule status" with "git submodule summary"-style change output.

> And - apart from the list of all submodules - the changes to them
> are given by "git status" and "git diff --submodule" too, right?

Oh, I didn't know about "git diff --submodule" at all.

> (sometimes I forget that "--submodule" is not enabled by default,
> as I'm a heavy "git gui" user, and that option is used there. We
> might need a config option to turn that on)

That's a good idea.  I'll write a patch tomorrow.

> Me too would expect a show command to show me a list of all the
> submodules and maybe some extra information (is it populated or
> not, does it have its .git directory embedded, does it contain
> changes). So maybe "show" should be a slightly pimped "status"?

Sure.  Do we want to create a new subcommand though?  Aren't "status"
and "summary" enough already?

Ram

  reply	other threads:[~2012-10-01 17:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-29 13:43 [PATCH] submodule: make 'show' an alias for 'summary' Ramkumar Ramachandra
2012-09-29 13:43 ` [PATCH] submodule: use abbreviated sha1 in 'status' output Ramkumar Ramachandra
2012-09-29 14:31   ` Jens Lehmann
2012-09-29 14:45     ` Ramkumar Ramachandra
2012-09-29 15:05       ` Jens Lehmann
2012-10-01  6:42         ` Ramkumar Ramachandra
2012-10-01 17:22           ` Jens Lehmann
2012-09-29 14:49 ` [PATCH] submodule: make 'show' an alias for 'summary' Jens Lehmann
2012-09-29 15:07   ` Ramkumar Ramachandra
2012-09-29 15:27     ` Jens Lehmann
2012-10-01  6:45       ` Ramkumar Ramachandra
2012-10-01 17:26         ` Jens Lehmann
2012-10-01 17:33           ` Ramkumar Ramachandra [this message]
2012-10-01 19:31             ` Jens Lehmann
2012-10-01 17:41           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALkWK0mQMe1zfbPNf5prjgTwFtPKJuK=uwxqAqN_Q2=76e-=mA@mail.gmail.com' \
    --to=artagnon@gmail.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).