git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc" <pclouds@gmail.com>,
	git@vger.kernel.org, "Johannes Sixt" <j6t@kdbg.org>
Subject: Re: [PATCH v3] gc: reject if another gc is running, unless --force is given
Date: Tue, 6 Aug 2013 12:15:49 +0530	[thread overview]
Message-ID: <CALkWK0m=QDq2mbW9L98qOpAx67heY-Z7VW_=DT83Z1o7+Lartw@mail.gmail.com> (raw)
In-Reply-To: <7vwqnzgvzi.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
>>> After reading what the whole function does, I think the purpose of
>>> this function is to take gc-lock (with optionally force).  Perhaps a
>>> name along the lines of "lock_gc", "gc_lock", "lock_repo_for_gc",
>>> would be more appropriate.
>>
>> The whole point of this exercise is to _not_ lock up the repo during
>> gc,...
>
> I do not think it is a misnomer to call the entity that locks other
> instances of gc's "a lock on the repository for gc".  Nothing in
> Duy's code suggests any other commands paying attention to this
> mechanism and stalling, and I think my comments were clear enough
> that I was not suggesting such a change.
>
> So I am not sure what you are complaining.

Not complaining; I wrote it down because of your "lock_repo_for_gc" suggestion.

  reply	other threads:[~2013-08-06  6:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  4:20 [PATCH] gc: reject if another gc is running, unless --force is given Nguyễn Thái Ngọc Duy
2013-08-03  6:21 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-08-03  7:52   ` Ramkumar Ramachandra
2013-08-03 10:01     ` Duy Nguyen
2013-08-03  9:49   ` Johannes Sixt
2013-08-03 10:01     ` Duy Nguyen
2013-08-03 10:40       ` Johannes Sixt
2013-08-05 14:19   ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2013-08-05 18:17     ` Junio C Hamano
2013-08-05 18:37       ` Ramkumar Ramachandra
2013-08-06  6:43         ` Junio C Hamano
2013-08-06  6:45           ` Ramkumar Ramachandra [this message]
2013-08-08 11:05     ` [PATCH v4] " Nguyễn Thái Ngọc Duy
2013-08-08 18:12       ` Junio C Hamano
2013-08-09 12:52         ` Duy Nguyen
2013-08-09 16:00           ` Junio C Hamano
2013-08-09 16:29       ` Andres Perera
2013-08-09 17:41         ` Junio C Hamano
2013-08-10  0:45         ` Duy Nguyen
2013-08-10  7:11           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALkWK0m=QDq2mbW9L98qOpAx67heY-Z7VW_=DT83Z1o7+Lartw@mail.gmail.com' \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).