From: Sahil Dua <sahildua2305@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Subject: [PATCH] config: mark a file-local symbol as static
Date: Sat, 17 Jun 2017 23:40:42 +0200 [thread overview]
Message-ID: <CALiud+nZj4f1=puzXC6grfStg-tQLMGpr-dAdtNwphyvts5KmA@mail.gmail.com> (raw)
In-Reply-To: <7d11fa4e-232b-8741-504f-ab4e3e788130@ramsayjones.plus.com>
Hi Ramsay,
Thanks for noticing. I will squash this into the relevant patch.
Also, git_config_copy_section_in_file() and refs_copy_existing_ref()
don't need to be available in public API.
Regards
Sahil Dua
Graduate Software Developer
Booking.com
Connect on LinkedIn
www.sahildua.com
On Thu, Jun 15, 2017 at 3:20 AM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Sahil,
>
> If you need to re-roll your 'sd/branch-copy' branch, could you please
> squash this into the relevant patch (commit 37af9c71b6, "config: create
> a function to format section headers", 13-06-2017).
>
> Also, I note that another patch in that branch (commit fd44da469c,
> "branch: add a --copy (-c) option to go with --move (-m)", 13-06-2017),
> adds a couple of external symbols which, currently, don't need to be
> externally visible. Is it intended that git_config_copy_section_in_file()
> and refs_copy_existing_ref() be part of the public API?
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config.c b/config.c
> index 2996e6d56..fbba17483 100644
> --- a/config.c
> +++ b/config.c
> @@ -2173,7 +2173,7 @@ static int write_error(const char *filename)
> return 4;
> }
>
> -struct strbuf store_create_section(const char *key)
> +static struct strbuf store_create_section(const char *key)
> {
> const char *dot;
> int i;
> --
> 2.13.0
next prev parent reply other threads:[~2017-06-17 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 1:20 Subject: [PATCH] config: mark a file-local symbol as static Ramsay Jones
2017-06-17 21:40 ` Sahil Dua [this message]
2017-06-17 22:00 ` Sahil Dua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALiud+nZj4f1=puzXC6grfStg-tQLMGpr-dAdtNwphyvts5KmA@mail.gmail.com' \
--to=sahildua2305@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).