git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jacob Godserv <jacobgodserv@gmail.com>
To: git@vger.kernel.org
Subject: git-svn aborts with "Use of uninitialized value $u" when a non-svn-backed branch is present in remote
Date: Tue, 22 Sep 2015 14:48:41 -0400	[thread overview]
Message-ID: <CALi1mtc8zmOzk-qv4XAg6N=ENasnMAENdJSLHK7EcpxRUk1nTw@mail.gmail.com> (raw)

I found a specific case in which git-svn improperly aborts:

1. I created a git-svn repository, named "git-svn repo", by cloned an
svn repository via the git-svn tool.
2. I created a normal git repository, named "configuration repo". I
renamed the master branch to "configuration". The initial commit adds
a README and some utility scripts.
3. I created a bare repository, named "master repo".
4. I pushed from the git-svn repo to the master repo.
5. I pushed from the configuration repo to the master repo.

The idea is the configuration branch, which is detached from any
git-svn history, can contain some useful tools, defaults, etc., that I
can share with teammates who want to use git on this svn project. It's
an odd use of git, but it has been working well.

However, a vanilla distribution of Git for Windows 2.5.2 produces the
following error when running any git-svn command, such as "git svn
info", on the cloned master repo:

Use of uninitialized value $u in substitution (s///) at
/mingw64/share/perl5/site_perl/Git/SVN.pm line 105.
Use of uninitialized value $u in concatenation (.) or string at
/mingw64/share/perl5/site_perl/Git/SVN.pm line 105.
refs/remotes/origin/configuration: 'svn+ssh://10.0.1.1/repos/projectA'
not found in ''

In the mentioned SVN.pm file, after the line:

                        my $u = (::cmt_metadata("$refname"))[0];

I added the following four lines:

                        if (not defined $u) {
                                warn "W: $refname does not exist in
SVN; skipping";
                                next;
                        }

git-svn appears to operate correctly with this patch. This is my first
time ever editing a perl script, so I apologize if I murdered an
adorable animal just now.

I'm sending this in so more knowledgeable git-svn developers can
comment on this and fix this in the official distribution of git,
assuming there is a bug here to fix.

-- 
    Jacob

             reply	other threads:[~2015-09-22 18:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 18:48 Jacob Godserv [this message]
2016-06-24 14:44 ` git-svn aborts with "Use of uninitialized value $u" when a non-svn-backed branch is present in remote Jacob Godserv
2016-06-24 19:35   ` Eric Wong
     [not found]     ` <CALi1mtc6Byb39kbAv16vmkUVu3JDdGG4-yVrLroDVraPDxGFng@mail.gmail.com>
2016-06-24 20:06       ` Eric Wong
2016-06-25  8:39         ` Christian Couder
2016-07-02 10:33           ` [PATCH] git-svn: warn instead of dying when commit data is missing Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALi1mtc8zmOzk-qv4XAg6N=ENasnMAENdJSLHK7EcpxRUk1nTw@mail.gmail.com' \
    --to=jacobgodserv@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).