From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Domingo Subject: Re: Fwd: possible Improving diff algoritm Date: Thu, 13 Dec 2012 00:32:53 +0100 Message-ID: References: <7vvcc73yzh.fsf@alter.siamese.dyndns.org> <7vpq2f2az4.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Junio C Hamano , Morten Welinder , Kevin , git To: Andrew Ardill X-From: git-owner@vger.kernel.org Thu Dec 13 00:33:36 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tivnw-0006oZ-OE for gcvg-git-2@plane.gmane.org; Thu, 13 Dec 2012 00:33:33 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754815Ab2LLXdP (ORCPT ); Wed, 12 Dec 2012 18:33:15 -0500 Received: from mail-qc0-f174.google.com ([209.85.216.174]:34136 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754466Ab2LLXdO (ORCPT ); Wed, 12 Dec 2012 18:33:14 -0500 Received: by mail-qc0-f174.google.com with SMTP id o22so1091641qcr.19 for ; Wed, 12 Dec 2012 15:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=yYgApS8M5J5CZJPS5g66UW56mM56as0gw7FSxONcTgg=; b=RyEl8sctjzhEtJ8kBpAMJhOokZ1XTLNZ4ieIi6/FJDnG/1j5qgRhUHRHgbQ5qscrJz tQqb+Z18XP4vl9ksBcWYPaNhlvhgp75vxreRWajG1UmU61VBVPnlDBGUuH78fWEnfJLN FmviKVbO+X4gmD0fumex+Dpb6KvR657EQM9QE67ivECrrDrQnAbcs39VGgL6rF8kFXu2 peD9Ysf1LTK3tjp2jx4Gz5rbqCQY/4S23ityFATKkR9NDOEB4dEMAbAZpmn5DVvFFGAB tPhaHH0SBWtRUReomt/Qk7IFBrzVR4LtAXqrbrSq1usVN6EMZnekOtqg2GN6qCgQuCdH Os/g== Received: by 10.224.107.3 with SMTP id z3mr171669qao.9.1355355194074; Wed, 12 Dec 2012 15:33:14 -0800 (PST) Received: by 10.49.63.68 with HTTP; Wed, 12 Dec 2012 15:32:53 -0800 (PST) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: I must say it is _quite_ helpfull having the diffs well done (natural diffs as here named), just because when you want to review a patch on the fly, this sort of things are annoying. I just wanted to say my opinion. No idea on how to fix that, nor why does it happen. Javier Domingo 2012/12/12 Andrew Ardill : > On 13 December 2012 08:53, Junio C Hamano wrote: >> The output being "a correct patch" is not the only thing we need to >> consider, though, as I mentioned in another response to Kevin >> regarding the "consequences". > > The main benefit of picking a more 'natural' diff is a usability one. > I know that when a chunk begins and ends one line after the logical > break point (typically with braces in my experience) mentally parsing > the diff becomes significantly harder. If there was a way to teach git > where it should try and break out a chunk (potentially per filetype?) > this is a good thing for readability, and I think would outweigh any > temporary pain with regards to cached rerere and diff data. > > Regards, > > Andrew Ardill > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html