From: Takuto Ikuta <tikuta@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack
Date: Mon, 27 Nov 2017 14:01:36 +0900 [thread overview]
Message-ID: <CALNjmMo3KH4QXY00ViVaiHdy=pSZ5j0BWRueO1T=sC_r0=3c3g@mail.gmail.com> (raw)
In-Reply-To: <xmqqk1yce301.fsf@gitster.mtv.corp.google.com>
2017-11-27 13:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:
> Jeff King <peff@peff.net> writes:
>
>>> cf. https://public-inbox.org/git/20171120202920.7ppcwmzkxifywtoj@sigill.intra.peff.net/
>>
>> It's funny that we'd get two patches so close together. AFAIK the
>> slowness here has been with us for years, and I just happened to
>> investigate it recently.
Yes, thank you for let me know.
Please ignore my patch, sorry.
>>
>>> The 5-patch series that contains the same change as this one is
>>> cooking and will hopefully be in the released version before the end
>>> of the year.
>>
>> I'd be curious if the 5th patch there provides an additional speedup for
>> Takuto's case.
>
> Indeed, it is a very good point.
>
> IIUC, the 5th one is about fetching tons of refs that you have never
> seen, right? If a repository that has trouble with everything-local
> is suffering because it right now has 300k remote-tracking branches,
> I'd imagine that these remote-tracking branches are being added at a
> considerable rate, so I'd not be surprised if these "new" refs
> benefits from that patch. And it would be nice to know how much a
> real life scenario actually does improve.
>
> Thanks.
In chromium repository, your 5th patch does not improve performance,
took more than 5 minutes to run fetch on windows.
4th patch is very important for the repository in daily fetch.
I hope your 4th patch will be merged.
Thanks.
--
Takuto Ikuta
Software Engineer in Tokyo
Chrome Infrastructure (goma team)
next prev parent reply other threads:[~2017-11-27 5:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 4:27 [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack Takuto Ikuta
2017-11-27 4:35 ` Junio C Hamano
2017-11-27 4:37 ` Jeff King
2017-11-27 4:53 ` Junio C Hamano
2017-11-27 5:01 ` Takuto Ikuta [this message]
2017-11-27 21:24 ` Johannes Schindelin
2017-11-27 23:52 ` Junio C Hamano
2017-11-28 0:33 ` Johannes Schindelin
2017-11-28 1:58 ` Takuto Ikuta
2017-11-28 11:27 ` Johannes Schindelin
2017-11-28 11:35 ` Takuto Ikuta
2017-11-27 5:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALNjmMo3KH4QXY00ViVaiHdy=pSZ5j0BWRueO1T=sC_r0=3c3g@mail.gmail.com' \
--to=tikuta@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).