From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Herland Subject: Re: [PATCH v4] notes: Allow treeish expressions as notes ref Date: Fri, 10 Jul 2015 09:16:16 +0200 Message-ID: References: <1436491711-19056-1-git-send-email-mh@glandium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Junio C Hamano , Git mailing list To: Mike Hommey X-From: git-owner@vger.kernel.org Fri Jul 10 09:16:42 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZDSXz-0007KP-4T for gcvg-git-2@plane.gmane.org; Fri, 10 Jul 2015 09:16:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbbGJHQ0 (ORCPT ); Fri, 10 Jul 2015 03:16:26 -0400 Received: from locusts.copyleft.no ([188.94.218.116]:57988 "EHLO mail.mailgateway.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752880AbbGJHQY (ORCPT ); Fri, 10 Jul 2015 03:16:24 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]) by mail.mailgateway.no with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.72 (FreeBSD)) (envelope-from ) id 1ZDSXm-0007fX-Ej for git@vger.kernel.org; Fri, 10 Jul 2015 09:16:22 +0200 Received: by ykee186 with SMTP id e186so56218553yke.2 for ; Fri, 10 Jul 2015 00:16:16 -0700 (PDT) X-Received: by 10.13.204.142 with SMTP id o136mr22378777ywd.171.1436512576541; Fri, 10 Jul 2015 00:16:16 -0700 (PDT) Received: by 10.37.92.2 with HTTP; Fri, 10 Jul 2015 00:16:16 -0700 (PDT) In-Reply-To: <1436491711-19056-1-git-send-email-mh@glandium.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Jul 10, 2015 at 3:28 AM, Mike Hommey wrote: > init_notes() is the main point of entry to the notes API. It is an arbitrary > restriction that all it allows as input is a strict ref name, when callers > may want to give an arbitrary treeish. > > However, some operations that require updating the notes tree require a > strict ref name, because they wouldn't be able to update e.g. foo@{1}. > > So we allow treeish expressions to be used in the case the notes tree is > going to be used without write "permissions", and to distinguish whether > the notes tree is intended to be used for reads only, or will be updated, > a flag is added. > > This has the side effect of enabling the use of treeish as notes refs in > commands allowing them, e.g. git log --notes=foo@{1}. Looks good. However, on a second pass I noticed that the patch comes with no tests. I'd like at least a couple of tests thrown in there to verify correctness; e.g. reading notes from refs/notes/commits^{tree} shall succeed, and trying to write notes to refs/notes/commits^{tree} shall fail. ...Johan -- Johan Herland, www.herland.net