From: Johan Herland <johan@herland.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Thomas Ferris Nicolaisen <tfnico@gmail.com>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [RFC/PATCHv2 2/3] git-svn: Warn about changing default for --prefix in Git v2.0
Date: Wed, 9 Oct 2013 14:18:11 +0200 [thread overview]
Message-ID: <CALKQrgd3wPEwK2vHkFPgt2hXASwB0ypAjzvnR8fV-WAgjggdqg@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cRAg4NpAsUWGQPsLcaFmDn61POv1pdHKCrSyQbM0KgM4A@mail.gmail.com>
On Wed, Oct 9, 2013 at 3:34 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Oct 5, 2013 at 7:30 PM, Johan Herland <johan@herland.net> wrote:
>> diff --git a/t/t9117-git-svn-init-clone.sh b/t/t9117-git-svn-init-clone.sh
>> index b7ef9e2..1c8d049 100755
>> --- a/t/t9117-git-svn-init-clone.sh
>> +++ b/t/t9117-git-svn-init-clone.sh
>> @@ -52,4 +52,71 @@ test_expect_success 'clone to target directory with --stdlayout' '
>> rm -rf target
>> '
>>
>> +test_expect_success 'clone without -s/-T/-b/-t does not warn' '
>> + test ! -d trunk &&
>> + git svn clone "$svnrepo"/project/trunk 2>warning &&
>> + test_must_fail grep -q prefix warning &&
>> + rm -rf trunk &&
>> + rm -f warning
>> + '
>> +
>> +test_svn_configured_prefix () {
>> + prefix=$1
>
> Did you want to maintain the &&-chain here?
>
>> + cat >expect <<EOF
>
> And here?
Yes, will add && in both places. Thanks.
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2013-10-09 12:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 9:02 git-svn: Use prefix by default? Thomas Ferris Nicolaisen
2013-09-30 22:39 ` Johan Herland
2013-09-30 22:46 ` [RFC/PATCH] git svn: Set default --prefix='origin/' if --prefix is not given Johan Herland
2013-10-01 4:07 ` Eric Wong
2013-10-01 6:12 ` Johan Herland
2013-10-03 19:01 ` Eric Wong
2013-10-05 23:30 ` [RFC/PATCHv2 1/3] Documentation/git-svn: Promote the use of --prefix in docs + examples Johan Herland
2013-10-05 23:30 ` [RFC/PATCHv2 2/3] git-svn: Warn about changing default for --prefix in Git v2.0 Johan Herland
2013-10-09 1:34 ` Eric Sunshine
2013-10-09 12:18 ` Johan Herland [this message]
2013-10-05 23:30 ` [RFC/PATCHv2 3/3] Git 2.0: git svn: Set default --prefix='origin/' if --prefix is not given Johan Herland
2013-10-06 9:51 ` [RFC/PATCHv2 1/3] Documentation/git-svn: Promote the use of --prefix in docs + examples Philip Oakley
2013-10-06 13:46 ` Johan Herland
2013-10-09 1:33 ` Eric Sunshine
2013-10-09 12:06 ` Johan Herland
2013-10-11 12:57 ` [RFC/PATCHv3 0/3] Change git-svn's default --prefix in Git v2.0 Johan Herland
2013-10-11 12:57 ` [RFC/PATCHv3 1/3] Documentation/git-svn: Promote the use of --prefix in docs + examples Johan Herland
2013-10-11 12:57 ` [RFC/PATCHv3 2/3] git-svn: Warn about changing default for --prefix in Git v2.0 Johan Herland
2013-10-12 22:33 ` Eric Wong
2013-10-11 12:57 ` [RFC/PATCHv3 3/3] Git 2.0: git svn: Set default --prefix='origin/' if --prefix is not given Johan Herland
2014-04-19 8:32 ` Eric Wong
2014-04-19 9:10 ` [PATCH] git-svn.txt: Retain a description og pre-v2.0 default prefix Johan Herland
2014-04-19 11:43 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALKQrgd3wPEwK2vHkFPgt2hXASwB0ypAjzvnR8fV-WAgjggdqg@mail.gmail.com \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=sunshine@sunshineco.com \
--cc=tfnico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).