git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Jonathan Nieder <jrnieder@gmail.com>,
	"Kyle J. McKay" <mackyle@gmail.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] Git v2.0.0-rc0
Date: Wed, 23 Apr 2014 09:33:40 +0200	[thread overview]
Message-ID: <CALKQrgd0Psp0nWUsmW16aR4io4xu_gumJmRdLGU+MOSzJvBobQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqbnvt2d7v.fsf@gitster.dls.corp.google.com>

On Wed, Apr 23, 2014 at 12:47 AM, Junio C Hamano <gitster@pobox.com> wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> What we could do instead is simply require a newer version of
>> Getopt::Long, which would let people continue using their ancient OSes
>> and install a newer version from CPAN if necessary.  It's also the
>> proper way to specify the dependency.
>
> Yes, but if its inability to properly grok --option="" is the only
> reason we want to add a dependency, wouldn't it suffice to simply
> state in the documentation (1) how to recognise the symptom to see
> if the version the user has is too old, e.g. "if you see this error
> message", "run 'perl -v' to see if your perl is older than X",
> etc. and (2) how to work it around, i.e. "instead of giving an empty
> value with --option='', say --option ''"?

FWIW, the least intrusive approach is what I find most agreeable:

 - Fix the tests to use --prefix "" instead of --prefix=""
 - Update the documentation like Junio suggests above.
 - Reformat an example using --prefix ""

I.e. use Kyle's patch to t9117, plus something like this:

diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index 5b3c38d..9f579e0 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -91,6 +91,9 @@ COMMANDS
 NOTE: Before Git v2.0, the default prefix was "" (no prefix). This
 meant that SVN-tracking refs were put at "refs/remotes/*", which is
 incompatible with how Git's own remote-tracking refs are organized.
+If you still want the old default, you can get it by passing
+'--prefix ""' on the command line ('--prefix=""' may not work if
+your Perl's Getopt::Long is < v2.37).

 --ignore-paths=<regex>;;
        When passed to 'init' or 'clone' this regular expression will



...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net

  reply	other threads:[~2014-04-23  7:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18 19:37 [ANNOUNCE] Git v2.0.0-rc0 Junio C Hamano
2014-04-19  1:13 ` Johan Herland
2014-04-19  7:20   ` Junio C Hamano
2014-04-20 19:08 ` Felipe Contreras
2014-04-20 21:14   ` Junio C Hamano
2014-04-22 11:16 ` Kyle J. McKay
2014-04-22 18:58   ` Jonathan Nieder
2014-04-22 20:12     ` Junio C Hamano
2014-04-22 21:00       ` Jonathan Nieder
2014-04-22 21:26         ` Junio C Hamano
2014-04-22 22:11           ` Jonathan Nieder
2014-04-22 22:25             ` brian m. carlson
2014-04-22 22:47               ` Junio C Hamano
2014-04-23  7:33                 ` Johan Herland [this message]
2014-04-23 16:40                   ` Junio C Hamano
2014-04-22 19:56   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALKQrgd0Psp0nWUsmW16aR4io4xu_gumJmRdLGU+MOSzJvBobQ@mail.gmail.com \
    --to=johan@herland.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=mackyle@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).