* (no subject)
@ 2019-02-28 10:43 Rohit Ashiwal
0 siblings, 0 replies; only message in thread
From: Rohit Ashiwal @ 2019-02-28 10:43 UTC (permalink / raw)
To: CACsJy8DjYUn+45E04gPjXhN0xqqjeyf8XoQsR8PyLefFrO4RGQ
Cc: Johannes Schindelin, Junio C Hamano, git, pclouds
Hey Duy
Sorry for late reply.
>
> On the Git mailing list, Duy Nguyen wrote (reply to this):
>
> I was a bit worried that the "test ! something" could be incorrectly
> converted because for example, "test ! -d foo" is not always the same
> as "test_path_is_missing". If "foo" is intended to be a file, then the
> conversion is wrong.
>
> But I don't think you made any wrong conversion here. All these
> negative "test" are preceded by "git rm" so the expectation is always
> "test ! -e".
>
Yes, I thought about it earlier and made
changes thinking this only. Also when I was going through the code
again, I replaced other conditionals `[ -f ]` with test_path_is_file
etc.
Ciao
Rohit
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-28 10:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 10:43 Rohit Ashiwal
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).